public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Andre Guedes <andre.guedes@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 4/8] Bluetooth: Add address type to struct sockaddr_l2
Date: Wed, 25 Apr 2012 08:45:58 +0200	[thread overview]
Message-ID: <1335336358.16897.409.camel@aeonflux> (raw)
In-Reply-To: <1335312176-21306-5-git-send-email-andre.guedes@openbossa.org>

Hi Andre,

> This patch adds the address type info to struct sockaddr_l2 so
> user-space can inform the remote device address type required
> to establish LE connections.
> 
> Soon, instead of looking the advertising cache up to discover the
> address type, we'll use this address type info to establish LE
> connections.
> 
> Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
> ---
>  include/net/bluetooth/l2cap.h |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
> index 0fac788..95741da 100644
> --- a/include/net/bluetooth/l2cap.h
> +++ b/include/net/bluetooth/l2cap.h
> @@ -57,6 +57,7 @@ struct sockaddr_l2 {
>  	__le16		l2_psm;
>  	bdaddr_t	l2_bdaddr;
>  	__le16		l2_cid;
> +	__u8		l2_bdaddr_type;
>  };

I am warming up to this naming. Does anybody have any objections?

Regards

Marcel



  reply	other threads:[~2012-04-25  6:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-25  0:02 [PATCH 0/8] LE Connection Andre Guedes
2012-04-25  0:02 ` [PATCH 1/8] Bluetooth: Move address type macros to bluetooth.h Andre Guedes
2012-04-25  0:02 ` [PATCH 2/8] Bluetooth: Rename link_to_mgmt to link_to_bdaddr Andre Guedes
2012-04-25  0:02 ` [PATCH 3/8] Bluetooth: Rename mgmt_to_le to bdaddr_to_le Andre Guedes
2012-04-25  0:02 ` [PATCH 4/8] Bluetooth: Add address type to struct sockaddr_l2 Andre Guedes
2012-04-25  6:45   ` Marcel Holtmann [this message]
2012-04-25  0:02 ` [PATCH 5/8] Bluetooth: Move bdaddr_to_le to hci_core Andre Guedes
2012-04-25  0:02 ` [PATCH 6/8] Bluetooth: Add dst_type parameter to hci_connect Andre Guedes
2012-04-25  0:02 ` [PATCH 7/8] Bluetooth: Use address type info from user-space Andre Guedes
2012-04-25  0:02 ` [PATCH 8/8] Bluetooth: Remove advertising cache Andre Guedes
2012-04-25  6:47 ` [PATCH 0/8] LE Connection Marcel Holtmann
2012-04-25  9:18   ` Johan Hedberg
2012-04-25  9:25     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335336358.16897.409.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox