linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: [PATCH BlueZ] mgmtops: Fix wrong parameter order for btd_event_ltk_notify()
Date: Fri, 27 Apr 2012 10:57:02 -0400	[thread overview]
Message-ID: <1335538622-8271-1-git-send-email-anderson.lizardo@openbossa.org> (raw)

The "master" parameter was in the wrong place.
---
 plugins/mgmtops.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

To those interested, this was not noticed before because:

* We don't use the stored information yet (although we will probably use soon
  the "authenticated" field for ATT requests that return "Insufficient
  Authentication")
* The storage types for master/authenticated/enc_size are compatible.

diff --git a/plugins/mgmtops.c b/plugins/mgmtops.c
index ddd544d..22fa329 100644
--- a/plugins/mgmtops.c
+++ b/plugins/mgmtops.c
@@ -1694,9 +1694,9 @@ static void mgmt_new_ltk(int sk, uint16_t index, void *buf, size_t len)
 
 	if (ev->store_hint) {
 		btd_event_ltk_notify(&info->bdaddr, &ev->key.addr.bdaddr,
-				ev->key.addr.type, ev->key.val,
+				ev->key.addr.type, ev->key.val, ev->key.master,
 				ev->key.authenticated, ev->key.enc_size,
-				ev->key.master, ev->key.ediv, ev->key.rand);
+				ev->key.ediv, ev->key.rand);
 	}
 
 	if (ev->key.master)
-- 
1.7.5.4


             reply	other threads:[~2012-04-27 14:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-27 14:57 Anderson Lizardo [this message]
2012-05-02 11:53 ` [PATCH BlueZ] mgmtops: Fix wrong parameter order for btd_event_ltk_notify() Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335538622-8271-1-git-send-email-anderson.lizardo@openbossa.org \
    --to=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).