linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz.oss@gmail.com>
Subject: [PATCH obexd v1 0/6] client: rethink transfer data access in session API
Date: Mon, 30 Apr 2012 17:26:21 +0200	[thread overview]
Message-ID: <1335799587-10370-1-git-send-email-mikel.astiz.oss@gmail.com> (raw)

This second version modifies patch v0 2/6 (now v1 3/6 due to new dependency) in order to use one single callback type in session API, according to the proposal from Luiz.

>From previous cover letter:

This patch series proposes a change in the session API such that the concept of "active transfer" (session->p) is removed from the API. This is possible once the callbacks provide the pointer to the transfer object, which can be used by the modules to access the data they are interested in.

This transfer object pointer is guaranteed to be valid during the duration of the callback, but nothing else can be assumed. In particular there is no ownership change involved.

The new approach is less error-prone and avoids API duplication between transfer and session APIs.

Mikel Astiz (6):
  client: Minor buffer access API changes
  client: Avoid GObex dependency from transfer.h
  client: Give transfer pointer in session callbacks
  client: Use new session callback style in modules
  client: Remove deprecated part of session API
  client: Remove transfer from queue before callback

 client/driver.c   |    2 +
 client/ftp.c      |   15 +++++---
 client/manager.c  |   14 ++++++--
 client/map.c      |   13 ++++---
 client/opp.c      |    3 ++
 client/pbap.c     |   27 +++++++++------
 client/session.c  |   93 ++++++++++++++--------------------------------------
 client/session.h  |    4 +--
 client/sync.c     |    4 ++-
 client/transfer.c |   14 ++++---
 client/transfer.h |    8 ++--
 11 files changed, 89 insertions(+), 108 deletions(-)

-- 
1.7.7.6


             reply	other threads:[~2012-04-30 15:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-30 15:26 Mikel Astiz [this message]
2012-04-30 15:26 ` [PATCH obexd v1 1/6] client: Minor buffer access API changes Mikel Astiz
2012-04-30 15:26 ` [PATCH obexd v1 2/6] client: Avoid GObex dependency from transfer.h Mikel Astiz
2012-04-30 15:26 ` [PATCH obexd v1 3/6] client: Give transfer pointer in session callbacks Mikel Astiz
2012-04-30 15:26 ` [PATCH obexd v1 4/6] client: Use new session callback style in modules Mikel Astiz
2012-04-30 15:26 ` [PATCH obexd v1 5/6] client: Remove deprecated part of session API Mikel Astiz
2012-04-30 15:26 ` [PATCH obexd v1 6/6] client: Remove transfer from queue before callback Mikel Astiz
2012-05-02 11:56 ` [PATCH obexd v1 0/6] client: rethink transfer data access in session API Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1335799587-10370-1-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).