* [PATCH BlueZ v1] audio: Reset hfp and hs handle before connection
@ 2012-05-02 11:36 Jaganath Kanakkassery
2012-05-02 11:41 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Jaganath Kanakkassery @ 2012-05-02 11:36 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Jaganath Kanakkassery
When bluez initiates headset connection hfp and hs handle is saved
each time when initiating connection. So at some point if hf service
is removed in remote headset then bluez connects to hs service. But
because of previously stored hfp handle bluez thinks that connection
made to hs service is hfp connection and waits for at commands.
Eventually bluez connection state will be incorrectly set.
---
audio/headset.c | 2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/audio/headset.c b/audio/headset.c
index f15951d..fb10c36 100644
--- a/audio/headset.c
+++ b/audio/headset.c
@@ -1464,9 +1464,11 @@ static int headset_set_channel(struct headset *headset,
if (svc == HANDSFREE_SVCLASS_ID) {
headset->hfp_handle = record->handle;
+ headset->hsp_handle = 0;
DBG("Discovered Handsfree service on channel %d", ch);
} else {
headset->hsp_handle = record->handle;
+ headset->hfp_handle = 0;
DBG("Discovered Headset service on channel %d", ch);
}
--
1.7.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH BlueZ v1] audio: Reset hfp and hs handle before connection
2012-05-02 11:36 [PATCH BlueZ v1] audio: Reset hfp and hs handle before connection Jaganath Kanakkassery
@ 2012-05-02 11:41 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2012-05-02 11:41 UTC (permalink / raw)
To: Jaganath Kanakkassery; +Cc: linux-bluetooth
Hi Jaganath,
On Wed, May 02, 2012, Jaganath Kanakkassery wrote:
> When bluez initiates headset connection hfp and hs handle is saved
> each time when initiating connection. So at some point if hf service
> is removed in remote headset then bluez connects to hs service. But
> because of previously stored hfp handle bluez thinks that connection
> made to hs service is hfp connection and waits for at commands.
> Eventually bluez connection state will be incorrectly set.
> ---
> audio/headset.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2012-05-02 11:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-05-02 11:36 [PATCH BlueZ v1] audio: Reset hfp and hs handle before connection Jaganath Kanakkassery
2012-05-02 11:41 ` Johan Hedberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).