From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [PATCH obexd v0 0/6] Create transfers in modules
Date: Fri, 4 May 2012 14:39:32 +0200 [thread overview]
Message-ID: <1336135178-21707-1-git-send-email-mikel.astiz.oss@gmail.com> (raw)
From: Mikel Astiz <mikel.astiz@bmw-carit.de>
This patch series changes the way transfers are created, as discussed in IRC. Instead of having the session API offer all common operations, the modules now use the transfer API directly, and then queue the transfer in the session using obc_session_queue().
The motivation behind this change is that the transfer-initiator module needs to have access to the created object, to be able to access some member variables. This is required for the D-Bus changes in the pipeline.
Another alternative to this patch series would be to simply return the transfer pointer in the session API for functions such as obc_session_get(). IMO this would actually be better.
Please review the changes with care (specially patch 6/6) since there is a lot of code rewrite.
Mikel Astiz (6):
client: Fix possible double free of params
client: Split internal obc_transfer_register()
client: Transfer API splits create and register
client: Buffer-passing changes in transfer API
client: Flip parameter order in transfer API
client: Create transfers in modules
client/ftp.c | 25 +++++++---
client/manager.c | 24 +++++++---
client/map.c | 18 ++++---
client/pbap.c | 30 +++++++-----
client/session.c | 130 +++++++++++++----------------------------------------
client/session.h | 17 ++-----
client/sync.c | 20 +++++---
client/transfer.c | 83 +++++++++++++++++----------------
client/transfer.h | 27 +++++-------
9 files changed, 163 insertions(+), 211 deletions(-)
--
1.7.7.6
next reply other threads:[~2012-05-04 12:39 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-04 12:39 Mikel Astiz [this message]
2012-05-04 12:39 ` [PATCH obexd v0 1/6] client: Fix possible double free of params Mikel Astiz
2012-05-04 12:39 ` [PATCH obexd v0 2/6] client: Split internal obc_transfer_register() Mikel Astiz
2012-05-04 12:39 ` [PATCH obexd v0 3/6] client: Transfer API splits create and register Mikel Astiz
2012-05-04 12:39 ` [PATCH obexd v0 4/6] client: Buffer-passing changes in transfer API Mikel Astiz
2012-05-04 12:39 ` [PATCH obexd v0 5/6] client: Flip parameter order " Mikel Astiz
2012-05-04 12:39 ` [PATCH obexd v0 6/6] client: Create transfers in modules Mikel Astiz
2012-05-15 7:44 ` [PATCH obexd v0 0/6] " Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336135178-21707-1-git-send-email-mikel.astiz.oss@gmail.com \
--to=mikel.astiz.oss@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=mikel.astiz@bmw-carit.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).