public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2] Bluetooth: mgmt: Fix device_connected sending order
Date: Sun, 06 May 2012 09:16:15 -0700	[thread overview]
Message-ID: <1336320975.5970.85.camel@aeonflux> (raw)
In-Reply-To: <1336128329-6650-1-git-send-email-johan.hedberg@gmail.com>

Hi Johan,

> The mgmt_ev_device_connected signal must be sent before any event
> indications happen for sockets associated with the connection. Otherwise
> e.g. device authorization for the sockets will fail with ENOTCONN as
> user space things that there is no baseband link.
> 
> This patch fixes the issue by ensuring that the device_connected event
> if sent (if it hasn't been so already) as soon as the first ACL data
> packet arrives from the remote device.
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> v2: Fixed missing hdev locking
> 
>  net/bluetooth/hci_core.c  |    8 ++++++++
>  net/bluetooth/hci_event.c |    4 ++--
>  2 files changed, 10 insertions(+), 2 deletions(-)

Acked-by: Marcel Holtmann <marcel@holtmann.org>

Regards

Marcel



  parent reply	other threads:[~2012-05-06 16:16 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-04 10:37 [PATCH] Bluetooth: mgmt: Fix device_connected sending order Johan Hedberg
2012-05-04 10:45 ` [PATCH v2] " Johan Hedberg
2012-05-04 19:51   ` Gustavo Padovan
2012-05-06 16:16   ` Marcel Holtmann [this message]
2012-05-07 17:57     ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336320975.5970.85.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox