From: Szymon Janc <szymon.janc@gmail.com>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 09/17] mcap: Fix possible overflow
Date: Tue, 17 Jun 2014 23:11:01 +0200 [thread overview]
Message-ID: <13363908.gOkADGD5ib@athlon> (raw)
In-Reply-To: <1402905472-17643-9-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
On Monday 16 June 2014 10:57:44 Andrei Emeltchenko wrote:
> From: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
>
> ---
> profiles/health/mcap_sync.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/profiles/health/mcap_sync.c b/profiles/health/mcap_sync.c
> index cc89d47..a0cc02a 100644
> --- a/profiles/health/mcap_sync.c
> +++ b/profiles/health/mcap_sync.c
> @@ -187,7 +187,7 @@ void mcap_sync_stop(struct mcap_mcl *mcl)
>
> static uint64_t time_us(struct timespec *tv)
> {
> - return tv->tv_sec * 1000000 + tv->tv_nsec / 1000;
> + return tv->tv_sec * 1000000ll + tv->tv_nsec / 1000ll;
> }
>
> static int64_t bt2us(int bt)
Commit message explaining why there is possible overflow would be nice.
--
Szymon K. Janc
szymon.janc@gmail.com
next prev parent reply other threads:[~2014-06-17 21:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-16 7:57 [PATCH 01/17] HDP: Fix checking always constant error code Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 02/17] " Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 03/17] android/HDP: Change scope of mdep Andrei Emeltchenko
2014-06-17 22:15 ` Szymon Janc
2014-06-16 7:57 ` [PATCH 04/17] android/gatt: Change DBG() to error() Andrei Emeltchenko
2014-06-17 21:22 ` Szymon Janc
2014-06-16 7:57 ` [PATCH 05/17] android/gatt: Fix wrong initial value Andrei Emeltchenko
2014-06-17 21:21 ` Szymon Janc
2014-06-18 8:46 ` Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 06/17] HDP: trivial: Make code more readable Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 07/17] android/gatt: Fix meory leak Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 08/17] HDP: Add length check Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 09/17] mcap: Fix possible overflow Andrei Emeltchenko
2014-06-17 21:11 ` Szymon Janc [this message]
2014-06-18 8:47 ` Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 10/17] android/hal-sco: Fix error code printing Andrei Emeltchenko
2014-06-17 21:49 ` Szymon Janc
2014-06-16 7:57 ` [PATCH 11/17] android/ipc-tester: Fix closing invalid fd Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 12/17] android/avrcp: Fix adding missing breaks Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 13/17] android/hal-audio: Remove dead code Andrei Emeltchenko
2014-06-17 20:27 ` Szymon Janc
2014-06-16 7:57 ` [PATCH 14/17] android/gatt: Fix error check Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 15/17] HDP: Fix possible memory leak Andrei Emeltchenko
2014-06-17 20:51 ` Szymon Janc
2014-06-18 8:52 ` Andrei Emeltchenko
2014-06-16 7:57 ` [PATCH 16/17] android/hal-sco: Remove unneeded statement Andrei Emeltchenko
2014-06-17 20:31 ` Szymon Janc
2014-06-16 7:57 ` [PATCH 17/17] android/hal-health: trivial: Remove empty line Andrei Emeltchenko
2014-06-17 7:20 ` [PATCH 01/17] HDP: Fix checking always constant error code Andrei Emeltchenko
2014-06-17 21:27 ` Szymon Janc
2014-06-18 8:54 ` Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 01/11] android/gatt: Change DBG() to error() Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 02/11] android/gatt: Fix wrong initial value Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 03/11] android/gatt: Fix memory leak Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 04/11] android/hal-health: trivial: Correct coding style Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 05/11] android/hal-msg: " Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 06/11] android/gatt: Fix warning by rearranging allocation Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 07/11] android/haltest: Auto-accept pairing Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 08/11] android/health: Remove unneeded check Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 09/11] android/health: Fix possible overflow Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 10/11] android/health: Fix missing error check Andrei Emeltchenko
2014-06-18 13:33 ` [PATCHv2 11/11] android/health: trivial: Remove empty line Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13363908.gOkADGD5ib@athlon \
--to=szymon.janc@gmail.com \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox