From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH obexd 2/3] client: Use signalfd to handle unix signals
Date: Mon, 7 May 2012 17:00:52 -0700 [thread overview]
Message-ID: <1336435253-19081-2-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1336435253-19081-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
client/main.c | 91 ++++++++++++++++++++++++++++++++++++++++++++++++++------
1 files changed, 81 insertions(+), 10 deletions(-)
diff --git a/client/main.c b/client/main.c
index 80f9413..6423f32 100644
--- a/client/main.c
+++ b/client/main.c
@@ -30,6 +30,8 @@
#include <string.h>
#include <signal.h>
#include <syslog.h>
+#include <unistd.h>
+#include <sys/signalfd.h>
#include <glib.h>
#include <gdbus.h>
@@ -39,6 +41,80 @@
static GMainLoop *event_loop = NULL;
+static unsigned int __terminated = 0;
+
+static gboolean signal_handler(GIOChannel *channel, GIOCondition cond,
+ gpointer user_data)
+{
+ struct signalfd_siginfo si;
+ ssize_t result;
+ int fd;
+
+ if (cond & (G_IO_NVAL | G_IO_ERR | G_IO_HUP))
+ return FALSE;
+
+ fd = g_io_channel_unix_get_fd(channel);
+
+ result = read(fd, &si, sizeof(si));
+ if (result != sizeof(si))
+ return FALSE;
+
+ switch (si.ssi_signo) {
+ case SIGINT:
+ case SIGTERM:
+ if (__terminated == 0) {
+ info("Terminating");
+ g_main_loop_quit(event_loop);
+ }
+
+ __terminated = 1;
+ break;
+ case SIGPIPE:
+ /* ignore */
+ break;
+ }
+
+ return TRUE;
+}
+
+static guint setup_signalfd(void)
+{
+ GIOChannel *channel;
+ guint source;
+ sigset_t mask;
+ int fd;
+
+ sigemptyset(&mask);
+ sigaddset(&mask, SIGINT);
+ sigaddset(&mask, SIGTERM);
+ sigaddset(&mask, SIGPIPE);
+
+ if (sigprocmask(SIG_BLOCK, &mask, NULL) < 0) {
+ perror("Failed to set signal mask");
+ return 0;
+ }
+
+ fd = signalfd(-1, &mask, 0);
+ if (fd < 0) {
+ perror("Failed to create signal descriptor");
+ return 0;
+ }
+
+ channel = g_io_channel_unix_new(fd);
+
+ g_io_channel_set_close_on_unref(channel, TRUE);
+ g_io_channel_set_encoding(channel, NULL, NULL);
+ g_io_channel_set_buffered(channel, FALSE);
+
+ source = g_io_add_watch(channel,
+ G_IO_IN | G_IO_HUP | G_IO_ERR | G_IO_NVAL,
+ signal_handler, NULL);
+
+ g_io_channel_unref(channel);
+
+ return source;
+}
+
static char *option_debug = NULL;
static gboolean option_stderr = FALSE;
@@ -62,16 +138,12 @@ static GOptionEntry options[] = {
{ NULL },
};
-static void sig_term(int sig)
-{
- g_main_loop_quit(event_loop);
-}
int main(int argc, char *argv[])
{
GOptionContext *context;
- struct sigaction sa;
GError *gerr = NULL;
+ guint signal;
context = g_option_context_new(NULL);
g_option_context_add_main_entries(context, options, NULL);
@@ -87,6 +159,8 @@ int main(int argc, char *argv[])
event_loop = g_main_loop_new(NULL, FALSE);
+ signal = setup_signalfd();
+
__obex_log_init("obex-client", option_debug, !option_stderr);
if (manager_init() < 0)
@@ -94,13 +168,10 @@ int main(int argc, char *argv[])
DBG("Entering main loop");
- memset(&sa, 0, sizeof(sa));
- sa.sa_handler = sig_term;
- sigaction(SIGINT, &sa, NULL);
- sigaction(SIGTERM, &sa, NULL);
-
g_main_loop_run(event_loop);
+ g_source_remove(signal);
+
manager_exit();
g_main_loop_unref(event_loop);
--
1.7.7.6
next prev parent reply other threads:[~2012-05-08 0:00 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-08 0:00 [PATCH obexd 1/3] core: Use signalfd to handle unix signals Luiz Augusto von Dentz
2012-05-08 0:00 ` Luiz Augusto von Dentz [this message]
2012-05-08 0:00 ` [PATCH obexd 3/3] client: Add handler for SIGUSR2 Luiz Augusto von Dentz
2012-05-08 6:16 ` Gustavo Padovan
2012-05-08 0:50 ` [PATCH obexd 1/3] core: Use signalfd to handle unix signals Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1336435253-19081-2-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).