public inbox for linux-bluetooth@vger.kernel.org
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/4] monitor: add device filter support
Date: Sun, 13 May 2012 19:58:46 -0700	[thread overview]
Message-ID: <1336964326.5970.238.camel@aeonflux> (raw)
In-Reply-To: <1336753132-8282-2-git-send-email-gustavo@padovan.org>

Hi Gustavo,

> -i hciX option will show only data from the specified device
> ---
>  monitor/main.c   |   12 ++++++++++--
>  monitor/packet.c |   10 +++++++++-
>  monitor/packet.h |    2 +-
>  3 files changed, 20 insertions(+), 4 deletions(-)

so what is this option actually good for? I think it is the wrong
approach for dealing with this.

We better have some generic filtering mechanism, then trying to just
duplicate options from hcidump into btmon.

btmon is different in the fact that it is actually able to record all
packets from all devices. You also do not wanna filter based on index
number. You wanna filter based on BD_ADDR and BR/EDR vs AMP.

Regards

Marcel



  parent reply	other threads:[~2012-05-14  2:58 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-11 16:18 [PATCH 1/4] monitor: remove extra black line Gustavo Padovan
2012-05-11 16:18 ` [PATCH 2/4] monitor: add device filter support Gustavo Padovan
2012-05-11 16:18   ` [PATCH 3/4] monitor: add command line filter options Gustavo Padovan
2012-05-11 16:18     ` [PATCH 4/4] monitor: show index only when -i is not specified Gustavo Padovan
2012-05-11 23:13   ` [PATCH 2/4] monitor: add device filter support Vinicius Costa Gomes
2012-05-14  2:58   ` Marcel Holtmann [this message]
2012-05-15 23:14     ` Gustavo Padovan
2012-05-16  1:54       ` Marcel Holtmann
2012-05-16 17:51         ` Marcel Holtmann
2012-05-11 16:20 ` [PATCH -v2 1/4] monitor: remove extra blank line Gustavo Padovan
2012-05-11 23:07 ` [PATCH 1/4] monitor: remove extra black line Vinicius Costa Gomes
2012-05-14  2:53 ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1336964326.5970.238.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox