From: Marcel Holtmann <marcel@holtmann.org>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ v5 09/13] gdbus: remove signatures from tables
Date: Wed, 16 May 2012 16:43:23 -0700 [thread overview]
Message-ID: <1337211803.5970.274.camel@aeonflux> (raw)
In-Reply-To: <1337211193-18230-10-git-send-email-lucas.demarchi@profusion.mobi>
Hi Lucas,
> attrib/client.c | 12 +++++-----
> audio/control.c | 18 +++++++--------
> audio/device.c | 13 +++++------
> audio/gateway.c | 16 ++++++-------
> audio/headset.c | 55 +++++++++++++++++++++------------------------
> audio/media.c | 8 +++----
> audio/sink.c | 25 +++++++++------------
> audio/source.c | 14 +++++-------
> audio/telephony-dummy.c | 18 +++++++--------
> audio/telephony-maemo5.c | 2 +-
> audio/transport.c | 10 ++++-----
> gdbus/gdbus.h | 3 ---
> gdbus/object.c | 2 +-
you can not intermix this. I want gdbus/ patches separated.
> diff --git a/gdbus/gdbus.h b/gdbus/gdbus.h
> index 610cb19..e9e8929 100644
> --- a/gdbus/gdbus.h
> +++ b/gdbus/gdbus.h
> @@ -91,8 +91,6 @@ typedef struct {
>
> typedef struct {
> const char *name;
> - const char *signature;
> - const char *reply;
> GDBusMethodFunction function;
> GDBusMethodFlags flags;
> unsigned int privilege;
> @@ -102,7 +100,6 @@ typedef struct {
>
> typedef struct {
> const char *name;
> - const char *signature;
> GDBusSignalFlags flags;
> const GDBusArgInfo *args;
> } GDBusSignalTable;
instead of removing these, why don't we make them NULL and start
using .function and .flags syntax for the method/signal tables as a
first step.
Regards
Marcel
next prev parent reply other threads:[~2012-05-16 23:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 23:33 [PATCH BlueZ v5 00/13] gdbus: Better D-Bus introspection Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 01/13] gdbus: return if method signature is malformed Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 02/13] gdbus: do not call memset for terminating NUL Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 03/13] Constify GDBus method tables Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 04/13] Constify GDBus signal tables Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 05/13] gdbus: add argument info to methods and signals Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 06/13] Convert GDBus methods and signals to use GDBusArgInfo Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 07/13] gdbus: use GDBusArgInfo to generate introspection Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 08/13] gdbus: loop over args to check message signature Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 09/13] gdbus: remove signatures from tables Lucas De Marchi
2012-05-16 23:43 ` Marcel Holtmann [this message]
2012-05-16 23:33 ` [PATCH BlueZ v5 10/13] gdbus: add Deprecated annotation in introspection Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 11/13] gdbus: add Method.NoReply " Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 12/13] gdbus: do not check signature twice Lucas De Marchi
2012-05-16 23:33 ` [PATCH BlueZ v5 13/13] adapter: " Lucas De Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337211803.5970.274.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).