From: Lucas De Marchi <lucas.demarchi@profusion.mobi>
To: linux-bluetooth@vger.kernel.org
Cc: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Subject: [PATCH BlueZ v6 15/15] adapter: do not check signature twice
Date: Thu, 17 May 2012 15:20:12 -0300 [thread overview]
Message-ID: <1337278812-4837-16-git-send-email-lucas.demarchi@profusion.mobi> (raw)
In-Reply-To: <1337278812-4837-1-git-send-email-lucas.demarchi@profusion.mobi>
Message signature is already checked in generic_message(), so there's no
need to check again in the callback.
---
src/adapter.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/src/adapter.c b/src/adapter.c
index e2e466d..dafe595 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -1317,9 +1317,6 @@ static DBusMessage *list_devices(DBusConnection *conn,
DBusMessageIter array_iter;
const gchar *dev_path;
- if (!dbus_message_has_signature(msg, DBUS_TYPE_INVALID_AS_STRING))
- return btd_error_invalid_args(msg);
-
reply = dbus_message_new_method_return(msg);
if (!reply)
return NULL;
--
1.7.10.2
prev parent reply other threads:[~2012-05-17 18:20 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-17 18:19 [PATCH BlueZ v6 00/15] gdbus: Better D-Bus introspection Lucas De Marchi
2012-05-17 18:19 ` [PATCH BlueZ v6 01/15] gdbus: return if method signature is malformed Lucas De Marchi
2012-05-18 2:53 ` Marcel Holtmann
2012-05-17 18:19 ` [PATCH BlueZ v6 02/15] gdbus: do not call memset for terminating NUL Lucas De Marchi
2012-05-18 2:54 ` Marcel Holtmann
2012-05-17 18:20 ` [PATCH BlueZ v6 03/15] Constify GDBus method tables Lucas De Marchi
2012-05-18 2:55 ` Marcel Holtmann
2012-05-17 18:20 ` [PATCH BlueZ v6 04/15] Constify GDBus signal tables Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 05/15] gdbus: add argument info to methods and signals Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 06/15] gdbus: add and use helpers for table declarations Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 07/15] Convert GDBus methods to use macro helpers Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 08/15] gdbus: use GDBusArgInfo to generate introspection Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 09/15] gdbus: loop over args to check message signature Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 10/15] Do not set signature and reply in GDBus tables Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 11/15] gdbus: remove signature and reply from tables Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 12/15] gdbus: add Deprecated annotation in introspection Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 13/15] gdbus: add Method.NoReply " Lucas De Marchi
2012-05-17 18:20 ` [PATCH BlueZ v6 14/15] gdbus: do not check signature twice Lucas De Marchi
2012-05-17 18:20 ` Lucas De Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337278812-4837-16-git-send-email-lucas.demarchi@profusion.mobi \
--to=lucas.demarchi@profusion.mobi \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).