From: Anderson Lizardo <anderson.lizardo@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Cc: Anderson Lizardo <anderson.lizardo@openbossa.org>
Subject: [PATCH RFC] avdtp: Fix incorrect gchar buffer allocation
Date: Fri, 18 May 2012 09:46:29 -0400 [thread overview]
Message-ID: <1337348789-21109-1-git-send-email-anderson.lizardo@openbossa.org> (raw)
The code was allocating an array of gchar pointers, where an array of
gchar is expected.
---
audio/gstavdtpsink.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
I did not check the code at length, but looking at other functions, this is
most likely a bug.
diff --git a/audio/gstavdtpsink.c b/audio/gstavdtpsink.c
index af04a56..b5dfae4 100644
--- a/audio/gstavdtpsink.c
+++ b/audio/gstavdtpsink.c
@@ -1144,7 +1144,7 @@ static gboolean gst_avdtp_sink_update_caps(GstAvdtpSink *self)
static gboolean gst_avdtp_sink_get_capabilities(GstAvdtpSink *self)
{
- gchar *buf[BT_SUGGESTED_BUFFER_SIZE];
+ gchar buf[BT_SUGGESTED_BUFFER_SIZE];
struct bt_get_capabilities_req *req = (void *) buf;
struct bt_get_capabilities_rsp *rsp = (void *) buf;
int err;
--
1.7.5.4
next reply other threads:[~2012-05-18 13:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 13:46 Anderson Lizardo [this message]
2012-05-22 9:59 ` [PATCH RFC] avdtp: Fix incorrect gchar buffer allocation Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337348789-21109-1-git-send-email-anderson.lizardo@openbossa.org \
--to=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).