From: Marcel Holtmann <marcel@holtmann.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH -v3] Bluetooth: Add MSG_MORE support to L2CAP sockets
Date: Fri, 18 May 2012 16:59:47 -0700 [thread overview]
Message-ID: <1337385587.2058.31.camel@aeonflux> (raw)
In-Reply-To: <1337384778-25135-1-git-send-email-gustavo@padovan.org>
Hi Gustavo,
> MSG_MORE enables us to save buffer space in userspace, the packet is
> built directly in the kernel and sent only when a msg with the MSG_MORE
> flag not set arrives. If a send() tries to add more chan->omtu bytes
> -EMSGSIZE is returned.
>
> Only MSG_MORE for Basic Mode is supported right now. chan->skb_more keeps
> a pointer to the L2CAP packet that is being build through many calls to
> send().
so this is really not acceptable. We need to start supporting all modes
with MSG_MORE at the same time. Otherwise we can not merge this.
Regards
Marcel
next prev parent reply other threads:[~2012-05-18 23:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-18 23:46 [PATCH -v3] Bluetooth: Add MSG_MORE support to L2CAP sockets Gustavo Padovan
2012-05-18 23:59 ` Marcel Holtmann [this message]
2012-05-25 22:25 ` Gustavo Padovan
2012-05-25 23:48 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1337385587.2058.31.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox