From: Marcel Holtmann <marcel@holtmann.org>
To: Gustavo Padovan <gustavo@padovan.org>
Cc: linux-bluetooth@vger.kernel.org,
Gustavo Padovan <gustavo.padovan@collabora.co.uk>
Subject: Re: [PATCH -v3 05/10] Bluetooth: Move check for backlog size to l2cap_sock.c
Date: Mon, 28 May 2012 05:59:04 +0200 [thread overview]
Message-ID: <1338177544.15105.118.camel@aeonflux> (raw)
In-Reply-To: <1338168480-9646-5-git-send-email-gustavo@padovan.org>
Hi Gustavo,
> Remove socket specific code from l2cap_core.c
>
> Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.co.uk>
> Acked-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/l2cap_core.c | 12 ------------
> net/bluetooth/l2cap_sock.c | 6 ++++++
> 2 files changed, 6 insertions(+), 12 deletions(-)
I applied this the first 5 patches to bluetooth-next so far.
<snip>
> diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
> index 5563023..d856cc8 100644
> --- a/net/bluetooth/l2cap_sock.c
> +++ b/net/bluetooth/l2cap_sock.c
> @@ -895,6 +895,12 @@ static struct l2cap_chan *l2cap_sock_new_connection_cb(struct l2cap_chan *chan)
> {
> struct sock *sk, *parent = chan->data;
>
> + /* Check for backlog size */
> + if (sk_acceptq_is_full(parent)) {
> + BT_DBG("backlog full %d", parent->sk_ack_backlog);
> + return NULL;
> + }
> +
> sk = l2cap_sock_alloc(sock_net(parent), NULL, BTPROTO_L2CAP,
> GFP_ATOMIC);
> if (!sk)
And on a side note, does this still have to be GFP_ATOMIC?
Regards
Marcel
next prev parent reply other threads:[~2012-05-28 3:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-28 1:27 [PATCH -v3 01/10] Bluetooth: Use chan as parameters for l2cap chan ops Gustavo Padovan
2012-05-28 1:27 ` [PATCH -v3 02/10] Bluetooth: Move clean up code and set of SOCK_ZAPPED to l2cap_sock.c Gustavo Padovan
2012-05-28 1:27 ` [PATCH -v3 03/10] Bluetooth: Add l2cap_chan->ops->ready() Gustavo Padovan
2012-05-28 1:27 ` [PATCH -v3 04/10] Bluetooth: Use chan->state instead of sk->sk_state Gustavo Padovan
2012-05-28 1:27 ` [PATCH -v3 05/10] Bluetooth: Move check for backlog size to l2cap_sock.c Gustavo Padovan
2012-05-28 3:59 ` Marcel Holtmann [this message]
2012-05-28 1:27 ` [PATCH -v3 06/10] Bluetooth: Create DEFER_SETUP flag in conf_state Gustavo Padovan
2012-05-28 1:27 ` [PATCH -v3 07/10] Bluetooth: Add chan->ops->defer() Gustavo Padovan
2012-05-28 3:54 ` Marcel Holtmann
2012-05-28 14:12 ` Andrei Emeltchenko
2012-05-28 16:23 ` Gustavo Padovan
2012-05-28 1:27 ` [PATCH -v3 08/10] Bluetooth: check for already existent channel before create new one Gustavo Padovan
2012-05-28 4:01 ` Marcel Holtmann
2012-05-28 1:27 ` [PATCH -v3 09/10] Bluetooth: Move bt_accept_enqueue() call to l2cap_sock.c Gustavo Padovan
2012-05-28 1:28 ` [PATCH -v3 10/10] Bluetooth: Remove parent socket usage from l2cap_core.c Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1338177544.15105.118.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=gustavo.padovan@collabora.co.uk \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox