From: Marcel Holtmann <marcel@holtmann.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH hcidump] Correct HCI version according to assign numbers
Date: Fri, 08 Jun 2012 12:43:57 +0900 [thread overview]
Message-ID: <1339127037.1817.137.camel@aeonflux> (raw)
In-Reply-To: <1339069794-25843-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> Bluetooth specifies assigned number for 0x05 as following:
> 5 - Bluetooth Core Specification 3.0 + HS
> http://www.bluetooth.org/Technical/AssignedNumbers/hci.htm
> ---
> lib/hci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/hci.c b/lib/hci.c
> index 269c021..0c1ef5e 100644
> --- a/lib/hci.c
> +++ b/lib/hci.c
> @@ -647,7 +647,7 @@ static hci_map ver_map[] = {
> { "1.2", 0x02 },
> { "2.0", 0x03 },
> { "2.1", 0x04 },
> - { "3.0", 0x05 },
> + { "3.0 + HS", 0x05 },
> { "4.0", 0x06 },
this is not correct. Please read the Bluetooth logo requirements. There
are BT controllers that are just 3.0 (without HS) and that is valid. The
addition of + HS is only valid if you have at least on AMP controller in
the system.
Regards
Marcel
prev parent reply other threads:[~2012-06-08 3:43 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-07 11:49 [PATCH hcidump] Correct HCI version according to assign numbers Andrei Emeltchenko
2012-06-08 3:43 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339127037.1817.137.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox