From: Marcel Holtmann <marcel@holtmann.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCHv1 3/4] Bluetooth: Add debug print specifier
Date: Fri, 08 Jun 2012 17:34:12 +0900 [thread overview]
Message-ID: <1339144452.1817.141.camel@aeonflux> (raw)
In-Reply-To: <1339143166-6523-3-git-send-email-Andrei.Emeltchenko.news@gmail.com>
Hi Andrei,
> Some functions print opcode as "0xc03" others as "0x0c03". Patch
> ensures that opcodes printed are the in the same format.
>
> Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
> ---
> net/bluetooth/hci_core.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
> index 8f35f2e..c7be1bc 100644
> --- a/net/bluetooth/hci_core.c
> +++ b/net/bluetooth/hci_core.c
> @@ -2097,7 +2097,7 @@ int hci_send_cmd(struct hci_dev *hdev, __u16 opcode, __u32 plen, void *param)
> struct hci_command_hdr *hdr;
> struct sk_buff *skb;
>
> - BT_DBG("%s opcode 0x%x plen %d", hdev->name, opcode, plen);
> + BT_DBG("%s opcode 0x%04x plen %d", hdev->name, opcode, plen);
please use 0x%4.4x to be consistent with our cases.
Regards
Marcel
next prev parent reply other threads:[~2012-06-08 8:34 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 8:12 [PATCHv1 1/4] Bluetooth: Use standard HCI cmd timeout for RESET Andrei Emeltchenko
2012-06-08 8:12 ` [PATCHv1 2/4] Bluetooth: Add opcode to error message Andrei Emeltchenko
2012-06-08 8:12 ` [PATCHv1 3/4] Bluetooth: Add debug print specifier Andrei Emeltchenko
2012-06-08 8:34 ` Marcel Holtmann [this message]
2012-06-08 8:12 ` [PATCHv1 4/4] Bluetooth: Fix not setting HCI_RESET flag for AMP Andrei Emeltchenko
2012-06-08 8:31 ` [PATCHv1 1/4] Bluetooth: Use standard HCI cmd timeout for RESET Marcel Holtmann
2012-06-08 8:53 ` Andrei Emeltchenko
2012-06-08 9:00 ` Andrei Emeltchenko
2012-06-08 9:01 ` Marcel Holtmann
2012-06-08 9:00 ` Marcel Holtmann
2012-06-08 9:11 ` Szymon Janc
2012-06-08 11:03 ` [PATCHv2 1/5] " Andrei Emeltchenko
2012-06-08 11:03 ` [PATCHv2 2/5] Bluetooth: Update HCI timeouts constants to use msecs_to_jiffies Andrei Emeltchenko
2012-06-08 11:03 ` [PATCHv2 3/5] Bluetooth: Add opcode to error message Andrei Emeltchenko
2012-06-08 11:17 ` Szymon Janc
2012-06-11 8:06 ` Andrei Emeltchenko
2012-06-08 11:03 ` [PATCHv2 4/5] Bluetooth: Correct debug print specifier for u16 objects Andrei Emeltchenko
2012-06-08 11:03 ` [PATCHv2 5/5] Bluetooth: Fix not setting HCI_RESET flag for AMP Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 1/5] Bluetooth: Use standard HCI cmd timeout for RESET Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 2/5] Bluetooth: Update HCI timeouts constants to use msecs_to_jiffies Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 3/5] Bluetooth: Add opcode to error message Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 4/5] Bluetooth: Correct debug print specifier for u16 objects Andrei Emeltchenko
2012-06-11 8:13 ` [PATCHv3 5/5] Bluetooth: Fix not setting HCI_RESET flag for AMP Andrei Emeltchenko
2012-06-12 3:15 ` Gustavo Padovan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1339144452.1817.141.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=Andrei.Emeltchenko.news@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).