linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Manoj Kumar Sharma <manojkr.sharma@stericsson.com>
Cc: linux-bluetooth@vger.kernel.org,
	Anurag Gupta <anurag.gupta@stericsson.com>
Subject: Re: [PATCH 0/2] Support for reserving bandwidth on L2CAP socket
Date: Tue, 24 Jul 2012 15:53:54 +0200	[thread overview]
Message-ID: <1343138034.24426.55.camel@aeonflux> (raw)
In-Reply-To: <1343123700-23375-1-git-send-email-manojkr.sharma@stericsson.com>

Hi Manoj,

> These patches allows L2CAP socket user to reserve bandwidth in
> percentage. Underlying socket reserves calculated number of
> HCI credits for this L2CAP channel.

this description is by far not enough. Explain why you are doing this.
And make it a detailed description. Preferable with hcidump traces
showing why this makes a difference at all.

Regards

Marcel



  parent reply	other threads:[~2012-07-24 13:53 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-24  9:54 [PATCH 0/2] Support for reserving bandwidth on L2CAP socket Manoj Kumar Sharma
2012-07-24  9:54 ` [PATCH 1/2] Bluetooth: Usage of HCI channels in L2CAP Manoj Kumar Sharma
2012-07-24  9:55   ` [PATCH 2/2] Bluetooth: L2CAP socket option to reserve bandwidth Manoj Kumar Sharma
2012-07-24 13:53 ` Marcel Holtmann [this message]
2012-07-27  5:14   ` [PATCH 0/2] Support for reserving bandwidth on L2CAP socket Manoj Sharma
2012-07-27 14:37     ` Marcel Holtmann
2012-07-30  6:30       ` Manoj Sharma
2012-07-30 16:11         ` Luiz Augusto von Dentz
2012-07-31 11:30           ` Manoj Sharma
2012-07-31 14:10             ` Luiz Augusto von Dentz
2012-07-31 16:58               ` Mat Martineau
2012-08-01 17:26                 ` Luiz Augusto von Dentz
2012-08-13  6:14                   ` Manoj Sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343138034.24426.55.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=anurag.gupta@stericsson.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=manojkr.sharma@stericsson.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).