Linux bluetooth development
 help / color / mirror / Atom feed
From: Andre Guedes <andre.guedes@openbossa.org>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH 3/7] Bluetooth: Remove unneeded code
Date: Fri, 27 Jul 2012 15:10:12 -0300	[thread overview]
Message-ID: <1343412616-25641-3-git-send-email-andre.guedes@openbossa.org> (raw)
In-Reply-To: <1343412616-25641-1-git-send-email-andre.guedes@openbossa.org>

This patch removes some unneeded code from hci_cs_le_create_conn.

If the hci_conn is not found, it means this LE connection attempt
was triggered by a thrid-party tool (e.g. hcitool). We should not
create this new hci_conn in LE Create Connection command status
event since it is already properly handled in LE Connection
Complete event.

Signed-off-by: Andre Guedes <andre.guedes@openbossa.org>
---
 net/bluetooth/hci_event.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/net/bluetooth/hci_event.c b/net/bluetooth/hci_event.c
index 8b13ccc..27064be 100644
--- a/net/bluetooth/hci_event.c
+++ b/net/bluetooth/hci_event.c
@@ -1638,16 +1638,6 @@ static void hci_cs_le_create_conn(struct hci_dev *hdev, __u8 status)
 			hci_proto_connect_cfm(conn, status);
 			hci_conn_del(conn);
 		}
-	} else {
-		if (!conn) {
-			conn = hci_conn_add(hdev, LE_LINK, &cp->peer_addr);
-			if (conn) {
-				conn->dst_type = cp->peer_addr_type;
-				conn->out = true;
-			} else {
-				BT_ERR("No memory for new connection");
-			}
-		}
 	}
 
 	hci_dev_unlock(hdev);
-- 
1.7.11.2


  parent reply	other threads:[~2012-07-27 18:10 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-27 18:10 [PATCH 1/7] Bluetooth: Trivial refactoring Andre Guedes
2012-07-27 18:10 ` [PATCH 2/7] Bluetooth: Fix hci_le_conn_complete_evt Andre Guedes
2012-07-27 18:10 ` Andre Guedes [this message]
2012-07-27 18:10 ` [PATCH 4/7] Bluetooth: Refactor hci_cs_le_create_conn Andre Guedes
2012-07-27 18:10 ` [PATCH 5/7] Bluetooth: Find hci_conn by BT_CONNECT state Andre Guedes
2012-07-27 18:10 ` [PATCH 6/7] Bluetooth: Lookup hci_conn in hci_le_conn_complete_evt Andre Guedes
2012-07-27 18:10 ` [PATCH 7/7] Bluetooth: Refactor " Andre Guedes
2012-08-06 18:16   ` Gustavo Padovan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1343412616-25641-3-git-send-email-andre.guedes@openbossa.org \
    --to=andre.guedes@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox