From: Marcel Holtmann <marcel@holtmann.org>
To: chanyeol.park@samsung.com
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/1] build: Remove gstreamer pkg config warning
Date: Tue, 31 Jul 2012 22:01:45 -0700 [thread overview]
Message-ID: <1343797305.1803.80.camel@aeonflux> (raw)
In-Reply-To: <1343797204-1202-1-git-send-email-chanyeol.park@samsung.com>
Hi Chan-yeol,
> From: Chan-yeol Park <chanyeol.park@samsung.com>
>
> GSTREAMER is not mandatory option when bluez build.
> ---
> acinclude.m4 | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/acinclude.m4 b/acinclude.m4
> index 6505ad3..6e3eb83 100644
> --- a/acinclude.m4
> +++ b/acinclude.m4
> @@ -106,8 +106,9 @@ AC_DEFUN([AC_PATH_GLIB], [
> ])
>
> AC_DEFUN([AC_PATH_GSTREAMER], [
> - PKG_CHECK_MODULES(GSTREAMER, gstreamer-0.10 >= 0.10.30 gstreamer-plugins-base-0.10, gstreamer_found=yes,
> - AC_MSG_WARN(GStreamer library version 0.10.30 or later is required);gstreamer_found=no)
> + PKG_CHECK_MODULES(GSTREAMER,
> + gstreamer-0.10 >= 0.10.30 gstreamer-plugins-base-0.10,
> + gstreamer_found=yes, gstreamer_found=no)
> AC_SUBST(GSTREAMER_CFLAGS)
> AC_SUBST(GSTREAMER_LIBS)
> GSTREAMER_PLUGINSDIR=`$PKG_CONFIG --variable=pluginsdir gstreamer-0.10`
as discussed during the BlueZ meeting, we will be removing GStreamer
support for BlueZ and submit it GStreamer. The prerequisite of the
standalone SBC library has been released yesterday.
So NAK on this patch since soon it will not be needed anymore.
Regards
Marcel
next prev parent reply other threads:[~2012-08-01 5:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-01 5:00 [PATCH 1/1] build: Remove gstreamer pkg config warning chanyeol.park
2012-08-01 5:01 ` Marcel Holtmann [this message]
2012-08-01 5:14 ` Chanyeol Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1343797305.1803.80.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=chanyeol.park@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).