From: Marcel Holtmann <marcel@holtmann.org>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ v3 1/3] rfcomm: Fix checking return value instead of errno
Date: Thu, 09 Aug 2012 22:56:43 -0700 [thread overview]
Message-ID: <1344578203.1780.5.camel@aeonflux> (raw)
In-Reply-To: <1344544143-12805-1-git-send-email-lucas.demarchi@profusion.mobi>
Hi Lucas,
> We were checking by a positive return value instead of checking by -1
> and errno. However when there's no support for TTY kernel returns
> EOPNOTSUPP as usual, which in the end will have a return value of -1
> and errno will be set to EOPNOTSUPP.
> ---
> tools/rfcomm.c | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
all 3 patches have been applied.
Regards
Marcel
prev parent reply other threads:[~2012-08-10 5:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-09 20:29 [PATCH BlueZ v3 1/3] rfcomm: Fix checking return value instead of errno Lucas De Marchi
2012-08-09 20:29 ` [PATCH BlueZ v3 2/3] rfcomm: Remove support for configuration file Lucas De Marchi
2012-08-09 20:29 ` [PATCH BlueZ v3 3/3] rfcomm: Fix typo in man page Lucas De Marchi
2012-08-10 5:56 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1344578203.1780.5.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox