From: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
To: linux-bluetooth@vger.kernel.org
Subject: [RFC hcidump 5/8] AVRCP: Add parsing for GetItemAttributes PDU
Date: Wed, 15 Aug 2012 16:32:06 +0300 [thread overview]
Message-ID: <1345037529-1828-5-git-send-email-luiz.dentz@gmail.com> (raw)
In-Reply-To: <1345037529-1828-1-git-send-email-luiz.dentz@gmail.com>
From: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
---
parser/avrcp.c | 129 ++++++++++++++++++++++++++++++++++++++++++++-------------
1 file changed, 101 insertions(+), 28 deletions(-)
diff --git a/parser/avrcp.c b/parser/avrcp.c
index 7059cb8..046368c 100644
--- a/parser/avrcp.c
+++ b/parser/avrcp.c
@@ -1718,6 +1718,41 @@ static const char *elementtype2str(uint8_t type)
return "Reserved";
}
+static void avrcp_attribute_entry_list_dump(int level, struct frame *frm,
+ uint8_t count)
+{
+ for (; count > 0; count--) {
+ uint32_t attr;
+ uint16_t charset;
+ uint8_t len;
+
+ p_indent(level, frm);
+
+ attr = get_u32(frm);
+ printf("AttributeID: 0x%08x (%s)\n", attr, mediattr2str(attr));
+
+ p_indent(level, frm);
+
+ charset = get_u16(frm);
+ printf("CharsetID: 0x%04x (%s)\n", charset,
+ charset2str(charset));
+
+ p_indent(level, frm);
+
+ len = get_u8(frm);
+ printf("AttributeLength: 0x%02x (%u)\n", len, len);
+
+ p_indent(level, frm);
+
+ printf("AttributeValue: ");
+ for (; len > 0; len--) {
+ uint8_t c = get_u8(frm);
+ printf("%1c", isprint(c) ? c : '.');
+ }
+ printf("\n");
+ }
+}
+
static void avrcp_media_element_item_dump(int level, struct frame *frm,
uint16_t len)
{
@@ -1763,34 +1798,7 @@ static void avrcp_media_element_item_dump(int level, struct frame *frm,
count = get_u8(frm);
printf("AttributeCount: 0x%02x (%u)\n", count, count);
- for (; count > 0; count--) {
- uint32_t attr;
-
- p_indent(level, frm);
-
- attr = get_u32(frm);
- printf("AttributeID: 0x%08x (%s)\n", attr, mediattr2str(attr));
-
- p_indent(level, frm);
-
- charset = get_u16(frm);
- printf("CharsetID: 0x%04x (%s)\n", charset,
- charset2str(charset));
-
- p_indent(level, frm);
-
- namelen = get_u8(frm);
- printf("AttributeLength: 0x%02x (%u)\n", namelen, namelen);
-
- p_indent(level, frm);
-
- printf("AttributeValue: ");
- for (; namelen > 0; namelen--) {
- uint8_t c = get_u8(frm);
- printf("%1c", isprint(c) ? c : '.');
- }
- printf("\n");
- }
+ avrcp_attribute_entry_list_dump(level, frm, count);
}
static void avrcp_get_folder_items_dump(int level, struct frame *frm,
@@ -1944,6 +1952,68 @@ response:
printf("Number of Items: 0x%04x (%u)", items, items);
}
+static void avrcp_get_item_attributes_dump(int level, struct frame *frm,
+ uint8_t hdr, uint16_t len)
+{
+ uint64_t uid;
+ uint32_t uidcounter;
+ uint8_t scope, count, status;
+
+ p_indent(level, frm);
+
+ if (hdr & 0x02)
+ goto response;
+
+ if (len < 12) {
+ printf("PDU Malformed\n");
+ raw_dump(level, frm);
+ return;
+ }
+
+ scope = get_u8(frm);
+ printf("Scope: 0x%02x (%s)\n", scope, scope2str(scope));
+
+ p_indent(level, frm);
+
+ uid = get_u64(frm);
+ printf("UID: 0x%16" PRIx64 " (%" PRIu64 ")\n", uid, uid);
+
+ p_indent(level, frm);
+
+ uidcounter = get_u16(frm);
+ printf("UIDCounter: 0x%04x (%u)\n", uidcounter, uidcounter);
+
+ p_indent(level, frm);
+
+ count = get_u32(frm);
+ printf("AttributeCount: 0x%04x (%u)", count, count);
+
+ for (; count > 0; count--) {
+ uint32_t attr;
+
+ p_indent(level, frm);
+
+ attr = get_u32(frm);
+ printf("AttributeID: 0x%08x (%s)\n", attr, mediattr2str(attr));
+ }
+
+ return;
+
+response:
+ status = get_u8(frm);
+ printf("Status: 0x%02x (%s)\n", status, error2str(status));
+
+ if (len == 1)
+ return;
+
+ p_indent(level, frm);
+
+ count = get_u32(frm);
+ printf("AttributeCount: 0x%04x (%u)", count, count);
+
+ avrcp_attribute_entry_list_dump(level, frm, count);
+}
+
static void avrcp_browsing_dump(int level, struct frame *frm, uint8_t hdr)
{
uint8_t pduid;
@@ -1971,6 +2041,9 @@ static void avrcp_browsing_dump(int level, struct frame *frm, uint8_t hdr)
case AVRCP_CHANGE_PATH:
avrcp_change_path_dump(level + 1, frm, hdr, len);
break;
+ case AVRCP_GET_ITEM_ATTRIBUTES:
+ avrcp_get_item_attributes_dump(level + 1, frm, hdr, len);
+ break;
default:
raw_dump(level, frm);
}
--
1.7.11.2
next prev parent reply other threads:[~2012-08-15 13:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-15 13:32 [RFC hcidump 1/8] AVRCP: Add initial support for browsing channel Luiz Augusto von Dentz
2012-08-15 13:32 ` [RFC hcidump 2/8] AVRCP: Fix parsing SetBrowsedPlayer as AV/C pdu Luiz Augusto von Dentz
2012-08-15 13:32 ` [RFC hcidump 3/8] AVRCP: Add parsing for GetFolderItems PDU Luiz Augusto von Dentz
2012-08-15 13:32 ` [RFC hcidump 4/8] AVRCP: Add parsing for ChangePath PDU Luiz Augusto von Dentz
2012-08-15 13:32 ` Luiz Augusto von Dentz [this message]
2012-08-15 13:32 ` [RFC hcidump 6/8] AVRCP: Add parsing for PlayItem PDU Luiz Augusto von Dentz
2012-08-15 13:32 ` [RFC hcidump 7/8] AVRCP: Add parsing for Search PDU Luiz Augusto von Dentz
2012-08-15 13:32 ` [RFC hcidump 8/8] AVRCP: Add parsing for AddToNowPlaying PDU Luiz Augusto von Dentz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1345037529-1828-5-git-send-email-luiz.dentz@gmail.com \
--to=luiz.dentz@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox