Linux bluetooth development
 help / color / mirror / Atom feed
From: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Cc: Tomasz Bursztyka <tomasz.bursztyka@linux.intel.com>
Subject: [PATCH 0/5] PAN server fixes
Date: Tue, 21 Aug 2012 13:45:50 +0300	[thread overview]
Message-ID: <1345545955-13144-1-git-send-email-tomasz.bursztyka@linux.intel.com> (raw)

Hi,

After looking at connman's bug https://bugs.meego.com/show_bug.cgi?id=25125 I figured out that PAN server code was missbehaving.
Basically, when DBus Unregister call is made: all bnep ifs and there corresponding connections are not touched at all, so on the
client side: it still thinks it's connected (it is, but it lost the tethering stuff and so on).

So here is a patch set that fixes the issue.

1 - it tracks the bnep interface per session, it will be necessary afterwards
2 - An helper to remove properly an interface from a bridge, it will be necessary afterwards also
3 - Here we are: it deletes the interface from the bridge, and puts it down when the server is freed. It's on its own function since it will be 
necessary aft
erwards.
4 - It kills the underlying connection properly so the client is notified as it should
5 - Finally, when Unregister method call is made: it cleans up all sessions so clients are disconnected accordingly etc...

Note: I tested this patch against 4.101 and it worken properly.

Please review,


Tomasz Bursztyka (5):
  network: Keep track of session's interface name in server
  network: Add helper function to remove an interface from a bridge
  network: Release session's interface from bridge when unregistering
  network: Kill underlying session's connection before freeing it
  network: Remove sessions from server on DBus call Unregister

 profiles/network/common.c |   29 +++++++++++++++++++++++++++++
 profiles/network/common.h |    1 +
 profiles/network/server.c |   31 ++++++++++++++++++++++++++++---
 3 files changed, 58 insertions(+), 3 deletions(-)

-- 
1.7.8.6


             reply	other threads:[~2012-08-21 10:45 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-08-21 10:45 Tomasz Bursztyka [this message]
2012-08-21 10:45 ` [PATCH 1/5] network: Keep track of session's interface name in server Tomasz Bursztyka
2012-08-21 10:45 ` [PATCH 2/5] network: Add helper function to remove an interface from a bridge Tomasz Bursztyka
2012-08-21 10:45 ` [PATCH 3/5] network: Release session's interface from bridge when unregistering Tomasz Bursztyka
2012-08-21 10:45 ` [PATCH 4/5] network: Kill underlying session's connection before freeing it Tomasz Bursztyka
2012-08-21 10:45 ` [PATCH 5/5] network: Remove sessions from server on DBus call Unregister Tomasz Bursztyka
2012-08-24  7:54 ` [PATCH 0/5] PAN server fixes Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1345545955-13144-1-git-send-email-tomasz.bursztyka@linux.intel.com \
    --to=tomasz.bursztyka@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox