linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org, gustavo@padovan.org
Cc: sunnyk@codeaurora.org
Subject: [RFCv1 19/20] Bluetooth: Do not retransmit data during a channel move
Date: Tue, 11 Sep 2012 11:21:30 -0700	[thread overview]
Message-ID: <1347387691-5285-20-git-send-email-mathewm@codeaurora.org> (raw)
In-Reply-To: <1347387691-5285-1-git-send-email-mathewm@codeaurora.org>

Do not retransmit previously-sent data when a "receiver ready" s-frame
with the "final" flag is received during a move.

The ERTM state machines will resynchronize at the end of a channel
move, and the state machine needs to avoid state changes during a
move.

Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
---
 net/bluetooth/l2cap_core.c | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index bde1303..35baa27 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -5580,8 +5580,9 @@ static int l2cap_rx_state_recv(struct l2cap_chan *chan,
 		if (control->final) {
 			clear_bit(CONN_REMOTE_BUSY, &chan->conn_state);
 
-			if (!test_and_clear_bit(CONN_REJ_ACT,
-						&chan->conn_state)) {
+			if (!test_and_clear_bit(CONN_REJ_ACT, &chan->conn_state)
+			    && (chan->move_state == L2CAP_MOVE_STABLE ||
+				chan->move_state == L2CAP_MOVE_WAIT_PREPARE)) {
 				control->final = 0;
 				l2cap_retransmit_all(chan, control);
 			}
-- 
1.7.12

--
Mat Martineau

The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

  parent reply	other threads:[~2012-09-11 18:21 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-11 18:21 [RFCv1 00/20] L2CAP signaling for AMP channel create/move Mat Martineau
2012-09-11 18:21 ` [RFCv1 01/20] Bluetooth: Add new l2cap_chan struct members for high speed channels Mat Martineau
2012-09-20 10:39   ` Andrei Emeltchenko
2012-10-01  8:29   ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 02/20] Bluetooth: Factor out common L2CAP connection code Mat Martineau
2012-10-01  8:30   ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 03/20] Bluetooth: Add L2CAP create channel request handling Mat Martineau
2012-09-25 11:39   ` Andrei Emeltchenko
2012-09-25 18:57     ` Mat Martineau
2012-10-01 10:16   ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 04/20] Bluetooth: Process create response and connect response identically Mat Martineau
2012-10-01  8:37   ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 05/20] Bluetooth: Lookup channel structure based on DCID Mat Martineau
2012-09-11 18:21 ` [RFCv1 06/20] Bluetooth: Channel move request handling Mat Martineau
2012-09-11 18:21 ` [RFCv1 07/20] Bluetooth: Add new ERTM receive states for channel move Mat Martineau
2012-09-11 18:21 ` [RFCv1 08/20] Bluetooth: Add move channel confirm handling Mat Martineau
2012-09-11 18:21 ` [RFCv1 09/20] Bluetooth: Add state to hci_chan Mat Martineau
2012-09-11 18:21 ` [RFCv1 10/20] Bluetooth: Move channel response Mat Martineau
2012-09-11 18:21 ` [RFCv1 11/20] Bluetooth: Add logical link confirm Mat Martineau
2012-09-11 18:21 ` [RFCv1 12/20] Bluetooth: Add move confirm response handling Mat Martineau
2012-09-11 18:21 ` [RFCv1 13/20] Bluetooth: Handle physical link completion Mat Martineau
2012-09-11 18:21 ` [RFCv1 14/20] Bluetooth: Flag ACL frames as complete for AMP controllers Mat Martineau
2012-09-11 18:21 ` [RFCv1 15/20] Bluetooth: Do not send data during channel move Mat Martineau
2012-09-11 18:21 ` [RFCv1 16/20] Bluetooth: Configure appropriate timeouts for AMP controllers Mat Martineau
2012-09-11 18:21 ` [RFCv1 17/20] Bluetooth: Ignore BR/EDR packet size constraints when fragmenting for AMP Mat Martineau
2012-10-01  8:46   ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 18/20] Bluetooth: Send create channel request instead of connect " Mat Martineau
2012-09-11 18:21 ` Mat Martineau [this message]
2012-09-11 18:21 ` [RFCv1 20/20] Bluetooth: Start channel move when socket option is changed Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1347387691-5285-20-git-send-email-mathewm@codeaurora.org \
    --to=mathewm@codeaurora.org \
    --cc=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=sunnyk@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).