From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org, gustavo@padovan.org
Cc: sunnyk@codeaurora.org
Subject: [RFCv1 20/20] Bluetooth: Start channel move when socket option is changed
Date: Tue, 11 Sep 2012 11:21:31 -0700 [thread overview]
Message-ID: <1347387691-5285-21-git-send-email-mathewm@codeaurora.org> (raw)
In-Reply-To: <1347387691-5285-1-git-send-email-mathewm@codeaurora.org>
Channel moves are triggered by changes to the BT_CHANNEL_POLICY
sockopt when an ERTM or streaming-mode channel is connected.
Moves are only started if enable_hs is true.
Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
---
include/net/bluetooth/l2cap.h | 1 +
net/bluetooth/l2cap_core.c | 20 ++++++++++++++++++++
net/bluetooth/l2cap_sock.c | 5 +++++
3 files changed, 26 insertions(+)
diff --git a/include/net/bluetooth/l2cap.h b/include/net/bluetooth/l2cap.h
index cfbde8f..b6a57c8 100644
--- a/include/net/bluetooth/l2cap.h
+++ b/include/net/bluetooth/l2cap.h
@@ -799,5 +799,6 @@ void l2cap_chan_set_defaults(struct l2cap_chan *chan);
int l2cap_ertm_init(struct l2cap_chan *chan);
void l2cap_chan_add(struct l2cap_conn *conn, struct l2cap_chan *chan);
void l2cap_chan_del(struct l2cap_chan *chan, int err);
+void l2cap_move_start(struct l2cap_chan *chan);
#endif /* __L2CAP_H */
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 35baa27..06942a8 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -4435,6 +4435,26 @@ static void l2cap_logical_cfm(struct l2cap_chan *chan, struct hci_chan *hchan,
}
}
+void l2cap_move_start(struct l2cap_chan *chan)
+{
+ BT_DBG("chan %p", chan);
+
+ if (chan->local_amp_id == 0) {
+ if (chan->chan_policy != BT_CHANNEL_POLICY_AMP_PREFERRED)
+ return;
+ chan->move_role = L2CAP_MOVE_ROLE_INITIATOR;
+ chan->move_state = L2CAP_MOVE_WAIT_PREPARE;
+ /* Placeholder - start physical link setup */
+ } else {
+ chan->move_role = L2CAP_MOVE_ROLE_INITIATOR;
+ chan->move_state = L2CAP_MOVE_WAIT_RSP_SUCCESS;
+ chan->move_id = 0;
+ l2cap_move_start(chan);
+ l2cap_send_move_chan_req(chan, 0);
+ __set_chan_timer(chan, L2CAP_MOVE_TIMEOUT);
+ }
+}
+
static void l2cap_do_create(struct l2cap_chan *chan, int result,
u8 local_amp_id, u8 remote_amp_id)
{
diff --git a/net/bluetooth/l2cap_sock.c b/net/bluetooth/l2cap_sock.c
index 13f6a98..f77f5a3 100644
--- a/net/bluetooth/l2cap_sock.c
+++ b/net/bluetooth/l2cap_sock.c
@@ -725,6 +725,11 @@ static int l2cap_sock_setsockopt(struct socket *sock, int level, int optname, ch
}
chan->chan_policy = (u8) opt;
+
+ if (sk->sk_state == BT_CONNECTED &&
+ chan->move_role == L2CAP_MOVE_ROLE_NONE)
+ l2cap_move_start(chan);
+
break;
default:
--
1.7.12
--
Mat Martineau
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation
prev parent reply other threads:[~2012-09-11 18:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-11 18:21 [RFCv1 00/20] L2CAP signaling for AMP channel create/move Mat Martineau
2012-09-11 18:21 ` [RFCv1 01/20] Bluetooth: Add new l2cap_chan struct members for high speed channels Mat Martineau
2012-09-20 10:39 ` Andrei Emeltchenko
2012-10-01 8:29 ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 02/20] Bluetooth: Factor out common L2CAP connection code Mat Martineau
2012-10-01 8:30 ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 03/20] Bluetooth: Add L2CAP create channel request handling Mat Martineau
2012-09-25 11:39 ` Andrei Emeltchenko
2012-09-25 18:57 ` Mat Martineau
2012-10-01 10:16 ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 04/20] Bluetooth: Process create response and connect response identically Mat Martineau
2012-10-01 8:37 ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 05/20] Bluetooth: Lookup channel structure based on DCID Mat Martineau
2012-09-11 18:21 ` [RFCv1 06/20] Bluetooth: Channel move request handling Mat Martineau
2012-09-11 18:21 ` [RFCv1 07/20] Bluetooth: Add new ERTM receive states for channel move Mat Martineau
2012-09-11 18:21 ` [RFCv1 08/20] Bluetooth: Add move channel confirm handling Mat Martineau
2012-09-11 18:21 ` [RFCv1 09/20] Bluetooth: Add state to hci_chan Mat Martineau
2012-09-11 18:21 ` [RFCv1 10/20] Bluetooth: Move channel response Mat Martineau
2012-09-11 18:21 ` [RFCv1 11/20] Bluetooth: Add logical link confirm Mat Martineau
2012-09-11 18:21 ` [RFCv1 12/20] Bluetooth: Add move confirm response handling Mat Martineau
2012-09-11 18:21 ` [RFCv1 13/20] Bluetooth: Handle physical link completion Mat Martineau
2012-09-11 18:21 ` [RFCv1 14/20] Bluetooth: Flag ACL frames as complete for AMP controllers Mat Martineau
2012-09-11 18:21 ` [RFCv1 15/20] Bluetooth: Do not send data during channel move Mat Martineau
2012-09-11 18:21 ` [RFCv1 16/20] Bluetooth: Configure appropriate timeouts for AMP controllers Mat Martineau
2012-09-11 18:21 ` [RFCv1 17/20] Bluetooth: Ignore BR/EDR packet size constraints when fragmenting for AMP Mat Martineau
2012-10-01 8:46 ` Andrei Emeltchenko
2012-09-11 18:21 ` [RFCv1 18/20] Bluetooth: Send create channel request instead of connect " Mat Martineau
2012-09-11 18:21 ` [RFCv1 19/20] Bluetooth: Do not retransmit data during a channel move Mat Martineau
2012-09-11 18:21 ` Mat Martineau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1347387691-5285-21-git-send-email-mathewm@codeaurora.org \
--to=mathewm@codeaurora.org \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=sunnyk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).