Linux bluetooth development
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [PATCH v1 0/4] Audio profile authorization
Date: Mon, 24 Sep 2012 17:42:14 +0200	[thread overview]
Message-ID: <1348501338-29639-1-git-send-email-mikel.astiz.oss@gmail.com> (raw)

From: Mikel Astiz <mikel.astiz@bmw-carit.de>

v1 of this patchset includes the modifications suggested by Luiz, most significantly the removal of the authorization hashmap in favor of code simplicity.

Additionally, a bug in v0 has been fixed affecting adapter_remove_device().

>From original cover-letter:

The agent-based profile authorization makes a special consideration for audio profiles: they are processed as if they all belonged to one single profile. This includes several internal policies that are inconvenient for IVI use-cases.

This patchset removes this exception by making use of the conventional authorization mechanism also for audio profiles.

The new approach is not straightforward since devices might send several connection requets in parallel (i.e. HFP, A2DP, AVRCP). This cannot be neither automatically rejected (EBUSY) nor forwarded in parallel to the agent, so a queue was added to store the pending authorization requests. These will be sent to the agent sequentially.

Mikel Astiz (4):
  adapter: Replace device authorizing flag
  adapter: Use authorization id for cancelling
  adapter: Queue parallel authorization requests
  audio: Drop audio-specific authorization mechanism

 audio/avctp.c           |   29 +++----
 audio/avdtp.c           |   25 ++++--
 audio/device.c          |  144 -----------------------------------
 audio/device.h          |   12 +---
 audio/manager.c         |   18 +++--
 plugins/service.c       |   18 +++--
 profiles/input/server.c |    2 +-
 src/adapter.c           |  194 ++++++++++++++++++++++++++++++----------------
 src/adapter.h           |    2 +-
 src/device.c            |   11 ---
 src/device.h            |    2 -
 11 files changed, 179 insertions(+), 278 deletions(-)

-- 
1.7.7.6


             reply	other threads:[~2012-09-24 15:42 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-09-24 15:42 Mikel Astiz [this message]
2012-09-24 15:42 ` [PATCH v1 1/4] adapter: Replace device authorizing flag Mikel Astiz
2012-09-24 15:42 ` [PATCH v1 2/4] adapter: Use authorization id for cancelling Mikel Astiz
2012-09-24 15:42 ` [PATCH v1 3/4] adapter: Queue parallel authorization requests Mikel Astiz
2012-09-25 10:07   ` Luiz Augusto von Dentz
2012-09-24 15:42 ` [PATCH v1 4/4] audio: Drop audio-specific authorization mechanism Mikel Astiz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1348501338-29639-1-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox