From: Marcel Holtmann <marcel@holtmann.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] build: Fix out-of-tree builds
Date: Mon, 01 Oct 2012 08:38:37 +0200 [thread overview]
Message-ID: <1349073517.13371.43.camel@aeonflux> (raw)
In-Reply-To: <1348861411-31555-1-git-send-email-anderson.lizardo@openbossa.org>
Hi Anderson,
> This commit makes a few changes that mostly affect "out-of-tree" builds:
>
> * Fix symlink creation for profiles/sap/sap.c (should use build
> directory, not source tree).
> * Remove useless -I$(builddir)/{tools,health} directives (these
> build directories do not contain any headers).
> * Add -I$(srcdir)/profiles/sap (necessary because sap.c is a symlink
> into the build directory, and refers to headers in the source tree).
>
> Tested with:
>
> ./bootstrap
> mkdir build
> cd build
> ../configure [...]
> ---
> Makefile.am | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/Makefile.am b/Makefile.am
> index c27eb01..257c18a 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -405,10 +405,10 @@ AM_CFLAGS += @DBUS_CFLAGS@ @GLIB_CFLAGS@
> INCLUDES = -I$(builddir)/lib -I$(builddir)/src -I$(srcdir)/src \
> -I$(srcdir)/audio -I$(srcdir)/sbc -I$(srcdir)/gdbus \
> -I$(srcdir)/attrib -I$(srcdir)/btio -I$(srcdir)/tools \
> - -I$(builddir)/tools -I$(srcdir)/monitor
> + -I$(srcdir)/monitor
>
> -if MCAP
> -INCLUDES += -I$(builddir)/health
> +if SAPPLUGIN
> +INCLUDES += -I$(srcdir)/profiles/sap
> endif
>
> unit_objects =
> @@ -447,7 +447,7 @@ audio/telephony.c: audio/@TELEPHONY_DRIVER@
> $(AM_V_GEN)$(LN_S) $(abs_top_builddir)/$< $@
>
> profiles/sap/sap.c: profiles/sap/@SAP_DRIVER@
> - $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
> + $(AM_V_GEN)$(LN_S) $(abs_top_builddir)/$< $@
>
> profiles/input/suspend.c: profiles/input/@HOG_SUSPEND_DRIVER@
> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
personally I am no longer a big fan of these selection of a specific
driver. We should be able to build all of them and make the selection at
runtime. So there is more work needed here.
Regards
Marcel
next prev parent reply other threads:[~2012-10-01 6:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 19:43 [PATCH BlueZ] build: Fix out-of-tree builds Anderson Lizardo
2012-10-01 6:38 ` Marcel Holtmann [this message]
2012-10-01 10:50 ` Anderson Lizardo
2012-10-01 14:53 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349073517.13371.43.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox