From: Marcel Holtmann <marcel@holtmann.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] build: Fix out-of-tree builds
Date: Mon, 01 Oct 2012 16:53:54 +0200 [thread overview]
Message-ID: <1349103234.23068.6.camel@aeonflux> (raw)
In-Reply-To: <CAJdJm_PpVLw6vC4Bf9gkjtpv9Fsx48-QFBoDAtWiBK9j47qE+w@mail.gmail.com>
Hi Anderson,
> >> profiles/sap/sap.c: profiles/sap/@SAP_DRIVER@
> >> - $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
> >> + $(AM_V_GEN)$(LN_S) $(abs_top_builddir)/$< $@
> >>
> >> profiles/input/suspend.c: profiles/input/@HOG_SUSPEND_DRIVER@
> >> $(AM_V_GEN)$(LN_S) $(abs_top_srcdir)/$< $@
> >
> > personally I am no longer a big fan of these selection of a specific
> > driver. We should be able to build all of them and make the selection at
> > runtime. So there is more work needed here.
>
> I agree, this could also help on testing as well (actually, all
> drivers are built, regardless of which one was selected by configure,
> but only the selected object is linked).
>
> What do you propose? a config file option, e.g. "sap_driver=u8500" ,
> "hog_suspend_driver=dummy" , etc (this could fit of the INI config
> format proposal).
something like that. I have no clear idea. So just go ahead and propose
a patch set for it. We then can review it.
Regards
Marcel
prev parent reply other threads:[~2012-10-01 14:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-28 19:43 [PATCH BlueZ] build: Fix out-of-tree builds Anderson Lizardo
2012-10-01 6:38 ` Marcel Holtmann
2012-10-01 10:50 ` Anderson Lizardo
2012-10-01 14:53 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349103234.23068.6.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).