Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Andrei Emeltchenko <Andrei.Emeltchenko.news@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: AMP: Register AMP only if High Speed enabled
Date: Thu, 04 Oct 2012 11:52:11 +0200	[thread overview]
Message-ID: <1349344331.27233.9.camel@aeonflux> (raw)
In-Reply-To: <1349339215-8422-1-git-send-email-Andrei.Emeltchenko.news@gmail.com>

Hi Andrei,

> Make sure that AMP controller is registered only if HS enables.
> Return EINVAL if High Speed is not enabled and dev_type is HCI_AMP.

I don't think this is a good idea. I like to keep the adapter registers,
but maybe have a hciconfig hciX up fail. Not the registration itself.

If you would fail the registration itself, then you have the problem
that you need to unplug and replug the hardware once you changed
enable_hs. And that might not always be possible.

Regards

Marcel



  reply	other threads:[~2012-10-04  9:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-04  8:26 [PATCH] Bluetooth: AMP: Register AMP only if High Speed enabled Andrei Emeltchenko
2012-10-04  9:52 ` Marcel Holtmann [this message]
2012-10-04 10:10   ` Andrei Emeltchenko
2012-10-04 10:26     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349344331.27233.9.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=Andrei.Emeltchenko.news@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox