From: Marcel Holtmann <marcel@holtmann.org>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: chanyeol.park@samsung.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 4/4] audio: Add check for non-a2dp codec
Date: Thu, 04 Oct 2012 20:08:27 +0200 [thread overview]
Message-ID: <1349374107.27233.36.camel@aeonflux> (raw)
In-Reply-To: <CABBYNZKHzKv+GQhynnGN04O17kwjDobwL-+CeVB9hJqrVEF05A@mail.gmail.com>
Hi Luiz,
> > This patch adds checks(vendor ID, vendor specific codec ID) to make sure of
> > non-a2dp codec selection.
> > ---
> > audio/a2dp-codecs.h | 6 +++++
> > audio/a2dp.c | 68 ++++++++++++++++++++++++++++++++++++++++++++++++++-
> > 2 files changed, 73 insertions(+), 1 deletion(-)
> >
> > diff --git a/audio/a2dp-codecs.h b/audio/a2dp-codecs.h
> > index 51c796a..e3d2cba 100644
> > --- a/audio/a2dp-codecs.h
> > +++ b/audio/a2dp-codecs.h
> > @@ -26,6 +26,7 @@
> > #define A2DP_CODEC_MPEG12 0x01
> > #define A2DP_CODEC_MPEG24 0x02
> > #define A2DP_CODEC_ATRAC 0x03
> > +#define A2DP_CODEC_NON_A2DP 0xFF
>
> I prefer A2DP_CODEC_VENDOR
what is the specification calling these? And yes, I would prefer VENDOR
as well.
Regards
Marcel
next prev parent reply other threads:[~2012-10-04 18:08 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-04 13:14 [PATCH 4/4] audio: Add check for non-a2dp codec chanyeol.park
2012-10-04 13:14 ` [PATCH 3/4] audio: Remove redundant procedure when a2dp connect chanyeol.park
2012-10-04 14:11 ` Luiz Augusto von Dentz
2012-10-04 13:14 ` [PATCH 2/4] audio: Remove unused function chanyeol.park
2012-10-04 13:14 ` [PATCH 1/4] mgmt: Add string for Passkey Notify Event chanyeol.park
2012-10-04 15:05 ` Johan Hedberg
2012-10-04 14:02 ` [PATCH 4/4] audio: Add check for non-a2dp codec Luiz Augusto von Dentz
2012-10-04 18:08 ` Marcel Holtmann [this message]
2012-10-04 20:22 ` Luiz Augusto von Dentz
2012-10-04 20:30 ` Marcel Holtmann
2012-10-05 2:37 ` Chan-yeol Park
2012-10-05 7:22 ` Chan-yeol Park
2012-10-05 8:41 ` Marcel Holtmann
2012-10-05 8:57 ` Chan-yeol Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349374107.27233.36.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=chanyeol.park@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).