From: Marcel Holtmann <marcel@holtmann.org>
To: Lucas De Marchi <lucas.demarchi@profusion.mobi>
Cc: Szymon Janc <szymon.janc@tieto.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/9] Pass confirm name as gboolean value
Date: Tue, 09 Oct 2012 18:12:24 +0200 [thread overview]
Message-ID: <1349799144.27233.100.camel@aeonflux> (raw)
In-Reply-To: <CAMOw1v51MT6AsyCB5X7GVRzbdDsXFJL=Gr5EO9ctJBT=vsBPHA@mail.gmail.com>
Hi Lucas,
> >> confirm_name is a boolean value and can be pass as such instead of
> >> uint8_t.
> >
> > actually long term I want to move to bool usage. So maybe this is a good
> > start to get this going.
>
> agreed... on new code that I'm adding I'm using bool.
>
> Btw, could we already use bool in gdbus/ ?
actually that one is heavily GLib specific. However if you are willing
to also clean up things like guint32, I have no problem with actually
converting that as well.
Getting rid of #include <glib/glib.h> in gdbus.h might be actually nice.
Regards
Marcel
next prev parent reply other threads:[~2012-10-09 16:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 12:11 [PATCH 0/9] Remove some old code Szymon Janc
2012-10-09 12:11 ` [PATCH 1/9] Simplify checking if found device is legacy Szymon Janc
2012-10-09 12:11 ` [PATCH 2/9] Pass confirm name as gboolean value Szymon Janc
2012-10-09 14:51 ` Marcel Holtmann
2012-10-09 15:49 ` Lucas De Marchi
2012-10-09 16:12 ` Marcel Holtmann [this message]
2012-10-10 9:57 ` Szymon Janc
2012-10-10 10:04 ` Marcel Holtmann
2012-10-09 12:11 ` [PATCH 3/9] event: Don't store EIR in btd_event_device_found Szymon Janc
2012-10-09 12:11 ` [PATCH 4/9] storage: Remove not used read_remote_eir Szymon Janc
2012-10-09 12:11 ` [PATCH 5/9] storage: Remove not used write_version_info Szymon Janc
2012-10-09 12:11 ` [PATCH 6/9] storage: Remove not used write_features_info Szymon Janc
2012-10-09 12:12 ` [PATCH 7/9] storage: Remove not used read_remote_features Szymon Janc
2012-10-09 12:12 ` [PATCH 8/9] adapter: Remove not used btd_adapter_switch_{online,offline} functions Szymon Janc
2012-10-09 12:12 ` [PATCH 9/9] device: Remove not used device_set_class function Szymon Janc
2012-10-09 14:30 ` [PATCH 0/9] Remove some old code Vinicius Costa Gomes
2012-10-09 16:39 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349799144.27233.100.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=lucas.demarchi@profusion.mobi \
--cc=szymon.janc@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox