From: Marcel Holtmann <marcel@holtmann.org>
To: Frederic Danis <frederic.danis@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 0/7] Move adapter config file to ini-file format
Date: Tue, 09 Oct 2012 18:21:44 +0200 [thread overview]
Message-ID: <1349799704.27233.102.camel@aeonflux> (raw)
In-Reply-To: <50744EB5.90900@linux.intel.com>
Hi Fred,
> >> Adapter saved configuration will be saved to /var/lib/bluetooth/<adapter address>/adapter
> >> in ini-file format for BlueZ 5.
> >> If this file does not exist, we try to convert old config file to it.
> >
> > since we are already using /config as file name, I propose we convert
> > this to /settings. I do not like the file name /adapter.
>
> OK, I will change it.
>
> > We need to make sure that once the new file exists, that we do not keep
> > converting over and over again.
>
> /config file is converted only if loading of new /settings file failed.
good. And then check if it got marked as converted yes and then just do
not convert twice.
> > I would also propose to add an extra entry to the old file that marks it
> > as converted. Then we can at some point in the future, start cleaning
> > out the leftovers.
>
> OK, I will add "converted yes" at end of /config file after conversion.
>
> Btw, should not we remove /config file after conversion ?
No. In case you go for and back between 4.x and 5.x we need to keep this
around for a bit. We should put a notice in the TODO file for some 5.x
version in lets say 6-8 month to start removing leftover config files.
Regards
Marcel
prev parent reply other threads:[~2012-10-09 16:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-09 15:58 [PATCH 0/7] Move adapter config file to ini-file format Frédéric Danis
2012-10-09 15:58 ` [PATCH 1/7] adapter: Read name in storage at init Frédéric Danis
2012-10-09 15:58 ` [PATCH 2/7] adapter: Read device class " Frédéric Danis
2012-10-09 15:58 ` [PATCH 3/7] adapter: Move pairable read to load_config() Frédéric Danis
2012-10-09 15:58 ` [PATCH 4/7] adapter: Read pairable timeout in storage at init Frédéric Danis
2012-10-09 15:58 ` [PATCH 5/7] adapter: Read discoverable " Frédéric Danis
2012-10-09 15:58 ` [PATCH 6/7] adapter: Read mode " Frédéric Danis
2012-10-09 15:58 ` [PATCH 7/7] adapter: Move saved config to ini-file format Frédéric Danis
2012-10-09 17:04 ` Anderson Lizardo
2012-10-09 16:08 ` [PATCH 0/7] Move adapter config file " Marcel Holtmann
2012-10-09 16:20 ` Frederic Danis
2012-10-09 16:21 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1349799704.27233.102.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=frederic.danis@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).