linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: "Frédéric Danis" <frederic.danis@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 0/7] Move adapter config file to ini-file format
Date: Wed, 10 Oct 2012 12:03:11 +0200	[thread overview]
Message-ID: <1349863391.27233.115.camel@aeonflux> (raw)
In-Reply-To: <1349859520-8824-1-git-send-email-frederic.danis@linux.intel.com>

Hi Fred,

> Adapter saved configuration will be saved to /var/lib/bluetooth/<adapter address>/settings
> in ini-file format for BlueZ 5.
> If this file does not exist, we try to convert legacy config file to it.
> 
> Access to variables during run-time is performed in adapter structure which is populated by loading saved configuration during initialization.
> 
> First 6 patches remove access to config file from run-time.
> Last patch move to ini-file format style (load, save and convert).

I am fine with the first 6 patches (7 in the end). Lets have Johan a
second look at it.

For the actual change to the new format, can you first create a document
describing the new format. Something like doc/settings-storage.txt or
similar (if anyone can think of a better name).

Regards

Marcel



  parent reply	other threads:[~2012-10-10 10:03 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-10  8:58 [PATCH v2 0/7] Move adapter config file to ini-file format Frédéric Danis
2012-10-10  8:58 ` [PATCH v2 1/7] adapter: Read name in storage at init Frédéric Danis
2012-10-10  9:57   ` Marcel Holtmann
2012-10-10  8:58 ` [PATCH v2 2/7] adapter: Read device class " Frédéric Danis
2012-10-10  8:58 ` [PATCH v2 3/7] adapter: Move pairable read to load_config() Frédéric Danis
2012-10-10  8:58 ` [PATCH v2 4/7] adapter: Read pairable timeout in storage at init Frédéric Danis
2012-10-10  8:58 ` [PATCH v2 5/7] adapter: Read discoverable " Frédéric Danis
2012-10-10  8:58 ` [PATCH v2 6/7] adapter: Read mode " Frédéric Danis
2012-10-10  8:58 ` [PATCH v2 7/7] adapter: Move saved config to ini-file format Frédéric Danis
2012-10-10 10:00   ` Marcel Holtmann
2012-10-10 10:03 ` Marcel Holtmann [this message]
2012-10-10 10:37   ` [PATCH v2 0/7] Move adapter config file " Anderson Lizardo
2012-10-10 13:01     ` Szymon Janc
2012-10-10 13:33   ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1349863391.27233.115.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=frederic.danis@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).