linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org, gustavo@padovan.org
Cc: sunnyk@codeaurora.org, marcel@holtmann.org
Subject: [PATCH 17/19] Bluetooth: Send create channel request instead of connect for AMP
Date: Mon, 15 Oct 2012 08:34:06 -0700	[thread overview]
Message-ID: <1350315248-7690-18-git-send-email-mathewm@codeaurora.org> (raw)
In-Reply-To: <1350315248-7690-1-git-send-email-mathewm@codeaurora.org>

When the channel policy is set to prefer AMP, then an L2CAP channel is
set up using the "create channel" command rather than the "connect"
command.  A physical link is also set up before sending "create
channel".

Behavior is unchanged if enable_hs is false.

Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
---
 net/bluetooth/l2cap_core.c | 42 ++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 3b142a0..57b1b02 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -58,6 +58,9 @@ static void l2cap_send_disconn_req(struct l2cap_conn *conn,
 static void l2cap_tx(struct l2cap_chan *chan, struct l2cap_ctrl *control,
 		     struct sk_buff_head *skbs, u8 event);
 
+static void l2cap_logical_cfm(struct l2cap_chan *chan, struct hci_chan *hchan,
+			      u8 status);
+
 /* ---- L2CAP channels ---- */
 
 static struct l2cap_chan *__l2cap_get_chan_by_dcid(struct l2cap_conn *conn,
@@ -562,6 +565,13 @@ void l2cap_chan_del(struct l2cap_chan *chan, int err)
 			mgr->bredr_chan = NULL;
 	}
 
+	if (chan->hs_hchan) {
+		chan->hs_hchan = NULL;
+		chan->hs_hcon = NULL;
+
+		/* Placeholder - free logical link */
+	}
+
 	chan->ops->teardown(chan, err);
 
 	if (test_bit(CONF_NOT_COMPLETE, &chan->conf_state))
@@ -1108,6 +1118,7 @@ static void l2cap_start_connection(struct l2cap_chan *chan)
 {
 	if (__amp_capable(chan)) {
 		BT_DBG("chan %p AMP capable: discover AMPs", chan);
+		set_bit(CONF_CONNECT_PEND, &chan->conf_state);
 		a2mp_discover_amp(chan);
 	} else {
 		l2cap_send_conn_req(chan);
@@ -1253,6 +1264,16 @@ static void l2cap_conn_start(struct l2cap_conn *conn)
 				rsp.status = __constant_cpu_to_le16(L2CAP_CS_AUTHEN_PEND);
 			}
 
+			if (rsp.result == __constant_cpu_to_le16(L2CAP_CR_SUCCESS) &&
+			    chan->local_amp_id) {
+				/* Placeholder - uncomment when amp functions
+				 * are available
+				amp_accept_physical(chan, chan->local_amp_id);
+				 */
+				l2cap_chan_unlock(chan);
+				continue;
+			}
+
 			l2cap_send_cmd(conn, chan->ident, L2CAP_CONN_RSP,
 				       sizeof(rsp), &rsp);
 
@@ -3344,6 +3365,18 @@ done:
 			rfc.mode = chan->mode;
 		}
 
+		if (test_bit(CONF_LOC_CONF_PEND, &chan->conf_state) &&
+		    chan->local_amp_id) {
+			struct hci_chan *hchan = NULL;
+
+			/* Placeholder - get hci_chan for logical link */
+
+			if (hchan && hchan->state == BT_CONNECTED) {
+				l2cap_logical_cfm(chan, hchan,
+						  L2CAP_MR_SUCCESS);
+			}
+		}
+
 		if (result == L2CAP_CONF_SUCCESS)
 			set_bit(CONF_OUTPUT_DONE, &chan->conf_state);
 	}
@@ -6354,6 +6387,15 @@ int l2cap_security_cfm(struct hci_conn *hcon, u8 status, u8 encrypt)
 					stat = L2CAP_CS_AUTHOR_PEND;
 					chan->ops->defer(chan);
 				} else {
+					if (chan->local_amp_id) {
+						/* Placeholder - accept physical
+						 * link
+						amp_accept_physical(chan,
+							chan->local_amp_id);
+						*/
+						continue;
+					}
+
 					__l2cap_state_change(chan, BT_CONFIG);
 					res = L2CAP_CR_SUCCESS;
 					stat = L2CAP_CS_NO_INFO;
-- 
1.7.12.3

--
Mat Martineau

Employee of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2012-10-15 15:34 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-15 15:33 [PATCH 00/19] L2CAP signaling for AMP channel create/move Mat Martineau
2012-10-15 15:33 ` [PATCH 01/19] Bluetooth: Add new l2cap_chan struct members for high speed channels Mat Martineau
2012-10-15 15:33 ` [PATCH 02/19] Bluetooth: Add L2CAP create channel request handling Mat Martineau
2012-10-15 15:33 ` [PATCH 03/19] Bluetooth: Remove unnecessary intermediate function Mat Martineau
2012-10-15 18:10   ` Marcel Holtmann
2012-10-15 15:33 ` [PATCH 04/19] Bluetooth: Lookup channel structure based on DCID Mat Martineau
2012-10-15 18:13   ` Marcel Holtmann
2012-10-15 15:33 ` [PATCH 05/19] Bluetooth: Channel move request handling Mat Martineau
2012-10-15 18:17   ` Marcel Holtmann
2012-10-16 10:18   ` Andrei Emeltchenko
2012-10-15 15:33 ` [PATCH 06/19] Bluetooth: Add new ERTM receive states for channel move Mat Martineau
2012-10-15 18:23   ` Marcel Holtmann
2012-10-16 10:21   ` Andrei Emeltchenko
2012-10-15 15:33 ` [PATCH 07/19] Bluetooth: Add move channel confirm handling Mat Martineau
2012-10-15 18:25   ` Marcel Holtmann
2012-10-16 17:30     ` Mat Martineau
2012-10-17 17:10       ` Marcel Holtmann
2012-10-16 10:27   ` Andrei Emeltchenko
2012-10-16 23:00     ` Mat Martineau
2012-10-15 15:33 ` [PATCH 08/19] Bluetooth: Add state to hci_chan Mat Martineau
2012-10-15 18:26   ` Marcel Holtmann
2012-10-15 15:33 ` [PATCH 09/19] Bluetooth: Move channel response Mat Martineau
2012-10-15 18:29   ` Marcel Holtmann
2012-10-16 17:56     ` Mat Martineau
2012-10-15 15:33 ` [PATCH 10/19] Bluetooth: Add logical link confirm Mat Martineau
2012-10-15 18:37   ` Marcel Holtmann
2012-10-16 10:38   ` Andrei Emeltchenko
2012-10-16 22:25     ` Mat Martineau
2012-10-15 15:34 ` [PATCH 11/19] Bluetooth: Add move confirm response handling Mat Martineau
2012-10-15 18:38   ` Marcel Holtmann
2012-10-15 15:34 ` [PATCH 12/19] Bluetooth: Handle physical link completion Mat Martineau
2012-10-15 18:40   ` Marcel Holtmann
2012-10-15 15:34 ` [PATCH 13/19] Bluetooth: Flag ACL frames as complete for AMP controllers Mat Martineau
2012-10-15 18:41   ` Marcel Holtmann
2012-10-15 15:34 ` [PATCH 14/19] Bluetooth: Do not send data during channel move Mat Martineau
2012-10-15 18:42   ` Marcel Holtmann
2012-10-16 10:50   ` Andrei Emeltchenko
2012-10-15 15:34 ` [PATCH 15/19] Bluetooth: Configure appropriate timeouts for AMP controllers Mat Martineau
2012-10-15 18:44   ` Marcel Holtmann
2012-10-15 15:34 ` [PATCH 16/19] Bluetooth: Ignore BR/EDR packet size constraints when fragmenting for AMP Mat Martineau
2012-10-15 15:34 ` Mat Martineau [this message]
2012-10-15 15:34 ` [PATCH 18/19] Bluetooth: Do not retransmit data during a channel move Mat Martineau
2012-10-15 18:46   ` Marcel Holtmann
2012-10-15 15:34 ` [PATCH 19/19] Bluetooth: Start channel move when socket option is changed Mat Martineau
2012-10-15 18:47   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350315248-7690-18-git-send-email-mathewm@codeaurora.org \
    --to=mathewm@codeaurora.org \
    --cc=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=sunnyk@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).