Re: [PATCH 05/11] Add simd primitive for 1b 8s analyse

[Marcel Holtmann <marcel@holtmann.org>]

Hi Fred,

> ---
>  sbc/sbc.c            |   12 +++++++---
>  sbc/sbc_primitives.c |   63 +++++++++++++++++++++++++++++++++++++++++++++++++-
>  sbc/sbc_primitives.h |    2 ++
>  3 files changed, 73 insertions(+), 4 deletions(-)
> 
> diff --git a/sbc/sbc.c b/sbc/sbc.c
> index c40aa15..fa90e07 100644
> --- a/sbc/sbc.c
> +++ b/sbc/sbc.c
> @@ -708,6 +708,10 @@ static int sbc_analyze_audio(struct sbc_encoder_state *state,
>  		for (ch = 0; ch < frame->channels; ch++) {
>  			x = &state->X[ch][state->position - 8 * state->inc +
>  							frame->blocks * 8];
> +
> +			if (state->pending == state->position)
> +				x += 8;
> +
>  			for (blk = 0; blk < frame->blocks; blk += state->inc) {
>  				state->sbc_analyze_4b_8s(
>  					state, x,
> @@ -904,13 +908,14 @@ static ssize_t sbc_pack_frame(uint8_t *data, struct sbc_frame *frame, size_t len
>  	}
>  }
>  
> -static void sbc_encoder_init(struct sbc_encoder_state *state,
> +static void sbc_encoder_init(int msbc, struct sbc_encoder_state *state,
>  					const struct sbc_frame *frame)
>  {

why not just unsigned long flags here instead of int msbc.

Regards

Marcel