From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org, gustavo@padovan.org
Cc: sunnyk@codeaurora.org, marcel@holtmann.org,
andrei.emeltchenko.news@gmail.com
Subject: [PATCHv3 10/18] Bluetooth: Add logical link confirm
Date: Thu, 18 Oct 2012 10:58:42 -0700 [thread overview]
Message-ID: <1350583130-3241-11-git-send-email-mathewm@codeaurora.org> (raw)
In-Reply-To: <1350583130-3241-1-git-send-email-mathewm@codeaurora.org>
The logical link confirm callback is executed when the AMP controller
completes its logical link setup. During a channel move, a newly
formed logical link allows a move responder to send a move channel
response. A move initiator will send a move channel confirm. A
failed logical link will end the channel move and send an appropriate
response or confirm command indicating a failure.
If the channel is being created on an AMP controller, L2CAP
configuration is started after the logical link is set up.
Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
---
net/bluetooth/l2cap_core.c | 120 ++++++++++++++++++++++++++++++++++++++++++++-
1 file changed, 118 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 7e50aa4..8e50685 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -3799,6 +3799,7 @@ static inline int l2cap_config_req(struct l2cap_conn *conn,
goto unlock;
}
+ chan->ident = cmd->ident;
l2cap_send_cmd(conn, cmd->ident, L2CAP_CONF_RSP, len, rsp);
chan->num_conf_rsp++;
@@ -4241,11 +4242,126 @@ static void l2cap_send_move_chan_cfm_rsp(struct l2cap_conn *conn, u8 ident,
l2cap_send_cmd(conn, ident, L2CAP_MOVE_CHAN_CFM_RSP, sizeof(rsp), &rsp);
}
+static void l2cap_logical_fail(struct l2cap_chan *chan)
+{
+ /* Logical link setup failed */
+ if (chan->state != BT_CONNECTED) {
+ /* Create channel failure, disconnect */
+ l2cap_send_disconn_req(chan->conn, chan, ECONNRESET);
+ } else if (chan->move_role == L2CAP_MOVE_ROLE_RESPONDER) {
+ l2cap_move_revert(chan);
+ chan->move_role = L2CAP_MOVE_ROLE_NONE;
+ chan->move_state = L2CAP_MOVE_STABLE;
+ l2cap_send_move_chan_rsp(chan->conn, chan->ident, chan->dcid,
+ L2CAP_MR_NOT_SUPP);
+ } else if (chan->move_role == L2CAP_MOVE_ROLE_INITIATOR) {
+ if (chan->move_state == L2CAP_MOVE_WAIT_LOGICAL_COMP ||
+ chan->move_state == L2CAP_MOVE_WAIT_LOGICAL_CFM) {
+ /* Remote has only sent pending or
+ * success responses, clean up
+ */
+ l2cap_move_revert(chan);
+ chan->move_role = L2CAP_MOVE_ROLE_NONE;
+ chan->move_state = L2CAP_MOVE_STABLE;
+ }
+
+ /* Other amp move states imply that the move
+ * has already aborted
+ */
+ l2cap_send_move_chan_cfm(chan->conn, chan, chan->scid,
+ L2CAP_MC_UNCONFIRMED);
+ __set_chan_timer(chan, L2CAP_MOVE_TIMEOUT);
+ }
+
+ chan->hs_hchan = NULL;
+ chan->hs_hcon = NULL;
+
+ /* Placeholder - free logical link */
+}
+
+static void l2cap_logical_create_channel(struct l2cap_chan *chan,
+ struct hci_chan *hchan)
+{
+ struct l2cap_conf_rsp rsp;
+ u8 code;
+
+ chan->hs_hcon = hchan->conn;
+ chan->hs_hcon->l2cap_data = chan->conn;
+
+ code = l2cap_build_conf_rsp(chan, &rsp,
+ L2CAP_CONF_SUCCESS, 0);
+ l2cap_send_cmd(chan->conn, chan->ident, L2CAP_CONF_RSP, code,
+ &rsp);
+ set_bit(CONF_OUTPUT_DONE, &chan->conf_state);
+
+ if (test_bit(CONF_INPUT_DONE, &chan->conf_state)) {
+ int err = 0;
+
+ set_default_fcs(chan);
+
+ err = l2cap_ertm_init(chan);
+ if (err < 0)
+ l2cap_send_disconn_req(chan->conn, chan, -err);
+ else
+ l2cap_chan_ready(chan);
+ }
+}
+
+static void l2cap_logical_move_channel(struct l2cap_chan *chan,
+ struct hci_chan *hchan)
+{
+ chan->hs_hcon = hchan->conn;
+ chan->hs_hcon->l2cap_data = chan->conn;
+
+ BT_DBG("move_state %d", chan->move_state);
+
+ switch (chan->move_state) {
+ case L2CAP_MOVE_WAIT_LOGICAL_COMP:
+ /* Move confirm will be sent after a success
+ * response is received
+ */
+ chan->move_state = L2CAP_MOVE_WAIT_RSP_SUCCESS;
+ break;
+ case L2CAP_MOVE_WAIT_LOGICAL_CFM:
+ if (test_bit(CONN_LOCAL_BUSY, &chan->conn_state)) {
+ chan->move_state = L2CAP_MOVE_WAIT_LOCAL_BUSY;
+ } else if (chan->move_role == L2CAP_MOVE_ROLE_INITIATOR) {
+ chan->move_state = L2CAP_MOVE_WAIT_CONFIRM_RSP;
+ l2cap_send_move_chan_cfm(chan->conn, chan, chan->scid,
+ L2CAP_MR_SUCCESS);
+ __set_chan_timer(chan, L2CAP_MOVE_TIMEOUT);
+ } else if (chan->move_role == L2CAP_MOVE_ROLE_RESPONDER) {
+ chan->move_state = L2CAP_MOVE_WAIT_CONFIRM;
+ l2cap_send_move_chan_rsp(chan->conn, chan->ident,
+ chan->dcid, L2CAP_MR_SUCCESS);
+ }
+ break;
+ default:
+ /* Move was not in expected state, free the channel */
+ chan->hs_hchan = NULL;
+ chan->hs_hcon = NULL;
+
+ /* Placeholder - free the logical link */
+
+ chan->move_state = L2CAP_MOVE_STABLE;
+ }
+}
+
+/* Call with chan locked */
static void l2cap_logical_cfm(struct l2cap_chan *chan, struct hci_chan *hchan,
u8 status)
{
- /* Placeholder */
- return;
+ BT_DBG("chan %p, hchan %p, status %d", chan, hchan, status);
+
+ if (status) {
+ l2cap_logical_fail(chan);
+ } else if (chan->state != BT_CONNECTED) {
+ /* Ignore logical link if channel is on BR/EDR */
+ if (chan->local_amp_id)
+ l2cap_logical_create_channel(chan, hchan);
+ } else {
+ l2cap_logical_move_channel(chan, hchan);
+ }
}
static inline int l2cap_move_channel_req(struct l2cap_conn *conn,
--
1.7.12.3
--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2012-10-18 17:58 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-18 17:58 [PATCHv3 00/18] L2CAP signaling for AMP channel create/move Mat Martineau
2012-10-18 17:58 ` [PATCHv3 01/18] Bluetooth: Add new l2cap_chan struct members for high speed channels Mat Martineau
2012-10-18 17:58 ` [PATCHv3 02/18] Bluetooth: Add L2CAP create channel request handling Mat Martineau
2012-10-18 17:58 ` [PATCHv3 03/18] Bluetooth: Remove unnecessary intermediate function Mat Martineau
2012-10-19 7:56 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 04/18] Bluetooth: Lookup channel structure based on DCID Mat Martineau
2012-10-19 7:57 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 05/18] Bluetooth: Channel move request handling Mat Martineau
2012-10-19 8:00 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 06/18] Bluetooth: Add new ERTM receive states for channel move Mat Martineau
2012-10-19 8:06 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 07/18] Bluetooth: Add move channel confirm handling Mat Martineau
2012-10-18 21:03 ` Marcel Holtmann
2012-10-19 8:07 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 08/18] Bluetooth: Add state to hci_chan Mat Martineau
2012-10-19 8:08 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 09/18] Bluetooth: Move channel response Mat Martineau
2012-10-18 21:05 ` Marcel Holtmann
2012-10-18 17:58 ` Mat Martineau [this message]
2012-10-18 21:08 ` [PATCHv3 10/18] Bluetooth: Add logical link confirm Marcel Holtmann
2012-10-19 21:21 ` Mat Martineau
2012-10-19 7:53 ` Andrei Emeltchenko
2012-10-19 16:44 ` Mat Martineau
2012-10-18 17:58 ` [PATCHv3 11/18] Bluetooth: Add move confirm response handling Mat Martineau
2012-10-19 8:25 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 12/18] Bluetooth: Handle physical link completion Mat Martineau
2012-10-19 8:32 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 13/18] Bluetooth: Flag ACL frames as complete for AMP controllers Mat Martineau
2012-10-19 8:44 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 14/18] Bluetooth: Do not send data during channel move Mat Martineau
2012-10-19 8:45 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 15/18] Bluetooth: Configure appropriate timeouts for AMP controllers Mat Martineau
2012-10-18 17:58 ` [PATCHv3 16/18] Bluetooth: Ignore BR/EDR packet size constraints when fragmenting for AMP Mat Martineau
2012-10-18 17:58 ` [PATCHv3 17/18] Bluetooth: Do not retransmit data during a channel move Mat Martineau
2012-10-19 8:48 ` Andrei Emeltchenko
2012-10-18 17:58 ` [PATCHv3 18/18] Bluetooth: Start channel move when socket option is changed Mat Martineau
2012-10-19 9:37 ` Andrei Emeltchenko
2012-10-19 16:16 ` Mat Martineau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1350583130-3241-11-git-send-email-mathewm@codeaurora.org \
--to=mathewm@codeaurora.org \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=sunnyk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).