Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 3/6] Bluetooth: Add initial support for LE-only controllers
Date: Fri, 19 Oct 2012 10:23:01 -0700	[thread overview]
Message-ID: <1350667381.1785.3.camel@aeonflux> (raw)
In-Reply-To: <1350666911-6334-4-git-send-email-johan.hedberg@gmail.com>

Hi Johan,

> This patch splits off most the HCI init sequence commands from a fixed
> set into a conditional one that is sent once the HCI_Read_Local_Features
> command completes. This is necessary since many of the current fixed
> commands are not allowed for LE-only controllers.
> 
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
>  net/bluetooth/hci_core.c  |   35 ---------------------------
>  net/bluetooth/hci_event.c |   58 +++++++++++++++++++++++++++++++++++++++++----
>  2 files changed, 53 insertions(+), 40 deletions(-)

I would merge this one with patch 1/6. Having them split up seems a bit
weird. Especially with 2/6 in between that has nothing to do with it.

Regards

Marcel



  reply	other threads:[~2012-10-19 17:23 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19 17:15 [PATCH 0/6] Bluetooth: Add basic support for single-mode controllers Johan Hedberg
2012-10-19 17:15 ` [PATCH 1/6] Bluetooth: Remove unnecessary LE init req from HCI core Johan Hedberg
2012-10-19 17:15 ` [PATCH 2/6] Bluetooth: Fix LE MTU reporting for HCIGETDEVINFO Johan Hedberg
2012-10-19 17:20   ` Marcel Holtmann
2012-10-19 17:15 ` [PATCH 3/6] Bluetooth: Add initial support for LE-only controllers Johan Hedberg
2012-10-19 17:23   ` Marcel Holtmann [this message]
2012-10-19 17:15 ` [PATCH 4/6] Bluetooth: Add setting of the LE event mask Johan Hedberg
2012-10-19 17:23   ` Marcel Holtmann
2012-10-19 17:15 ` [PATCH 5/6] Bluetooth: Fix HCI command sending when powering on LE-only adapters Johan Hedberg
2012-10-19 17:24   ` Marcel Holtmann
2012-10-19 17:15 ` [PATCH 6/6] Bluetooth: Read adversiting channel TX power during init sequence Johan Hedberg
2012-10-19 17:25   ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350667381.1785.3.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=johan.hedberg@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox