linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org, gustavo@padovan.org
Cc: sunnyk@codeaurora.org, marcel@holtmann.org,
	andrei.emeltchenko.news@gmail.com,
	Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Subject: [PATCHv4 16/18] Bluetooth: Ignore BR/EDR packet size constraints when fragmenting for AMP
Date: Fri, 19 Oct 2012 14:34:07 -0700	[thread overview]
Message-ID: <1350682449-24818-17-git-send-email-mathewm@codeaurora.org> (raw)
In-Reply-To: <1350682449-24818-1-git-send-email-mathewm@codeaurora.org>

When operating over BR/EDR, ERTM accounts for the maximum over-the-air
packet size when setting the PDU size.  AMP controllers do not use the
same over-the-air packets, so the PDU size should only be based on the
HCI MTU of the AMP controller.

Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
Signed-off-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
---
 net/bluetooth/l2cap_core.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index 2d3fc42..84ab0db 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -2285,7 +2285,9 @@ static int l2cap_segment_sdu(struct l2cap_chan *chan,
 	/* PDU size is derived from the HCI MTU */
 	pdu_len = chan->conn->mtu;
 
-	pdu_len = min_t(size_t, pdu_len, L2CAP_BREDR_MAX_PAYLOAD);
+	/* Constrain PDU size for BR/EDR connections */
+	if (!chan->hs_hcon)
+		pdu_len = min_t(size_t, pdu_len, L2CAP_BREDR_MAX_PAYLOAD);
 
 	/* Adjust for largest possible L2CAP overhead. */
 	if (chan->fcs)
-- 
1.7.12.3

--
Mat Martineau

Employee of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2012-10-19 21:34 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-19 21:33 [PATCHv4 00/18] L2CAP signaling for AMP channel create/move Mat Martineau
2012-10-19 21:33 ` [PATCHv4 01/18] Bluetooth: Add new l2cap_chan struct members for high speed channels Mat Martineau
2012-10-19 21:33 ` [PATCHv4 02/18] Bluetooth: Add L2CAP create channel request handling Mat Martineau
2012-10-19 21:33 ` [PATCHv4 03/18] Bluetooth: Remove unnecessary intermediate function Mat Martineau
2012-10-19 21:33 ` [PATCHv4 04/18] Bluetooth: Lookup channel structure based on DCID Mat Martineau
2012-10-19 21:33 ` [PATCHv4 05/18] Bluetooth: Channel move request handling Mat Martineau
2012-10-19 21:33 ` [PATCHv4 06/18] Bluetooth: Add new ERTM receive states for channel move Mat Martineau
2012-10-19 21:33 ` [PATCHv4 07/18] Bluetooth: Add move channel confirm handling Mat Martineau
2012-10-19 21:33 ` [PATCHv4 08/18] Bluetooth: Add state to hci_chan Mat Martineau
2012-10-19 21:34 ` [PATCHv4 09/18] Bluetooth: Move channel response Mat Martineau
2012-10-19 21:34 ` [PATCHv4 10/18] Bluetooth: Add logical link confirm Mat Martineau
2012-10-23 18:53   ` Marcel Holtmann
2012-10-23 19:27     ` Mat Martineau
2012-10-23 21:51       ` Marcel Holtmann
2012-10-19 21:34 ` [PATCHv4 11/18] Bluetooth: Add move confirm response handling Mat Martineau
2012-10-19 21:34 ` [PATCHv4 12/18] Bluetooth: Handle physical link completion Mat Martineau
2012-10-19 21:34 ` [PATCHv4 13/18] Bluetooth: Flag ACL frames as complete for AMP controllers Mat Martineau
2012-10-19 21:34 ` [PATCHv4 14/18] Bluetooth: Do not send data during channel move Mat Martineau
2012-10-19 21:34 ` [PATCHv4 15/18] Bluetooth: Configure appropriate timeouts for AMP controllers Mat Martineau
2012-10-19 21:34 ` Mat Martineau [this message]
2012-10-19 21:34 ` [PATCHv4 17/18] Bluetooth: Do not retransmit data during a channel move Mat Martineau
2012-10-19 21:34 ` [PATCHv4 18/18] Bluetooth: Start channel move when socket option is changed Mat Martineau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1350682449-24818-17-git-send-email-mathewm@codeaurora.org \
    --to=mathewm@codeaurora.org \
    --cc=andrei.emeltchenko.news@gmail.com \
    --cc=andrei.emeltchenko@intel.com \
    --cc=gustavo@padovan.org \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=marcel@holtmann.org \
    --cc=sunnyk@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).