From: Marcel Holtmann <marcel@holtmann.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: Johan Hedberg <johan.hedberg@gmail.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/7] Bluetooth: mgmt: Restrict BR/EDR settings to BR/EDR-only adapters
Date: Tue, 23 Oct 2012 12:03:09 -0700 [thread overview]
Message-ID: <1351018989.1785.46.camel@aeonflux> (raw)
In-Reply-To: <CAJdJm_PoB=e_pi2gAN4AOn_ETyHz3nDihUy8yu2bthe0+p5cxw@mail.gmail.com>
Hi Anderson,
> > @@ -377,15 +377,15 @@ static u32 get_supported_settings(struct hci_dev *hdev)
> > u32 settings = 0;
> >
> > settings |= MGMT_SETTING_POWERED;
> > - settings |= MGMT_SETTING_CONNECTABLE;
> > - settings |= MGMT_SETTING_FAST_CONNECTABLE;
> > - settings |= MGMT_SETTING_DISCOVERABLE;
> > settings |= MGMT_SETTING_PAIRABLE;
> >
> > if (lmp_ssp_capable(hdev))
> > settings |= MGMT_SETTING_SSP;
> >
> > if (lmp_bredr_capable(hdev)) {
> > + settings |= MGMT_SETTING_CONNECTABLE;
> > + settings |= MGMT_SETTING_FAST_CONNECTABLE;
> > + settings |= MGMT_SETTING_DISCOVERABLE;
> > settings |= MGMT_SETTING_BREDR;
> > settings |= MGMT_SETTING_LINK_SECURITY;
>
> "Discoverable" (at least as a Discovery mode from GAP) is mandatory
> for LE Peripheral role (see page 1698). Same for "Connectable" (see
> page 1706).
>
> Unless you have other plans to implement this for single mode LE
> peripherals running bluez?
at this moment, we plan to keep LE a bit independent from BR/EDR.
Regards
Marcel
next prev parent reply other threads:[~2012-10-23 19:03 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 16:53 [PATCH 0/7] Bluetooth: Improved single-mode and LE peripheral support Johan Hedberg
2012-10-23 16:53 ` [PATCH 1/7] Bluetooth: mgmt: Add support for switching to LE peripheral mode Johan Hedberg
2012-10-23 19:01 ` Marcel Holtmann
2012-10-23 20:26 ` Johan Hedberg
2012-10-23 21:49 ` Marcel Holtmann
2012-10-23 16:53 ` [PATCH 2/7] Bluetooth: mgmt: Restrict BR/EDR settings to BR/EDR-only adapters Johan Hedberg
2012-10-23 18:51 ` Anderson Lizardo
2012-10-23 19:03 ` Marcel Holtmann [this message]
2012-10-23 19:02 ` Marcel Holtmann
2012-10-23 19:31 ` Anderson Lizardo
2012-10-23 20:48 ` Johan Hedberg
2012-10-23 21:46 ` Marcel Holtmann
2012-10-24 12:11 ` Anderson Lizardo
2012-10-24 15:14 ` Marcel Holtmann
2012-10-23 16:53 ` [PATCH 3/7] Bluetooth: Disallow LE scanning and connecting in peripheral mode Johan Hedberg
2012-10-23 18:42 ` Anderson Lizardo
2012-10-23 20:59 ` Johan Hedberg
2012-10-23 21:37 ` Marcel Holtmann
2012-10-23 16:53 ` [PATCH 4/7] Bluetooth: Add support for setting LE advertising data Johan Hedberg
2012-10-23 18:30 ` Anderson Lizardo
2012-10-23 21:26 ` Johan Hedberg
2012-10-25 0:00 ` Anderson Lizardo
2012-10-23 16:53 ` [PATCH 5/7] Bluetooth: Fix updating host feature bits for LE Johan Hedberg
2012-10-23 19:04 ` Marcel Holtmann
2012-10-23 16:54 ` [PATCH 6/7] Bluetooth: Sort feature test macros by bitmask location Johan Hedberg
2012-10-23 19:06 ` Marcel Holtmann
2012-10-23 16:54 ` [PATCH 7/7] Bluetooth: Make use feature test macros Johan Hedberg
2012-10-23 19:06 ` Marcel Holtmann
-- strict thread matches above, loose matches on Subject: below --
2012-10-24 18:11 [PATCH 0/7 v2] Bluetooth: LE single-mode & peripheral role fixes Johan Hedberg
2012-10-24 18:11 ` [PATCH 2/7] Bluetooth: mgmt: Restrict BR/EDR settings to BR/EDR-only adapters Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351018989.1785.46.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=anderson.lizardo@openbossa.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).