From: Mat Martineau <mathewm@codeaurora.org>
To: linux-bluetooth@vger.kernel.org, gustavo@padovan.org
Cc: sunnyk@codeaurora.org, marcel@holtmann.org,
andrei.emeltchenko.news@gmail.com
Subject: [PATCHv5 17/18] Bluetooth: Do not retransmit data during a channel move
Date: Tue, 23 Oct 2012 15:24:22 -0700 [thread overview]
Message-ID: <1351031063-11791-18-git-send-email-mathewm@codeaurora.org> (raw)
In-Reply-To: <1351031063-11791-1-git-send-email-mathewm@codeaurora.org>
Do not retransmit previously-sent data when a "receiver ready" s-frame
with the "final" flag is received during a move.
The ERTM state machines will resynchronize at the end of a channel
move, and the state machine needs to avoid state changes during a
move.
Signed-off-by: Mat Martineau <mathewm@codeaurora.org>
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Acked-by: Andrei Emeltchenko <andrei.emeltchenko@intel.com>
---
net/bluetooth/l2cap_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/bluetooth/l2cap_core.c b/net/bluetooth/l2cap_core.c
index ef86ebb..93f1ebb 100644
--- a/net/bluetooth/l2cap_core.c
+++ b/net/bluetooth/l2cap_core.c
@@ -5591,8 +5591,8 @@ static int l2cap_rx_state_recv(struct l2cap_chan *chan,
if (control->final) {
clear_bit(CONN_REMOTE_BUSY, &chan->conn_state);
- if (!test_and_clear_bit(CONN_REJ_ACT,
- &chan->conn_state)) {
+ if (!test_and_clear_bit(CONN_REJ_ACT, &chan->conn_state) &&
+ !__chan_is_moving(chan)) {
control->final = 0;
l2cap_retransmit_all(chan, control);
}
--
1.8.0
--
Mat Martineau
Employee of Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation
next prev parent reply other threads:[~2012-10-23 22:24 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-23 22:24 [PATCHv5 00/18] L2CAP signaling for AMP channel create/move Mat Martineau
2012-10-23 22:24 ` [PATCHv5 01/18] Bluetooth: Add new l2cap_chan struct members for high speed channels Mat Martineau
2012-10-23 22:24 ` [PATCHv5 02/18] Bluetooth: Add L2CAP create channel request handling Mat Martineau
2012-10-23 22:24 ` [PATCHv5 03/18] Bluetooth: Remove unnecessary intermediate function Mat Martineau
2012-10-23 22:24 ` [PATCHv5 04/18] Bluetooth: Lookup channel structure based on DCID Mat Martineau
2012-10-23 22:24 ` [PATCHv5 05/18] Bluetooth: Channel move request handling Mat Martineau
2012-10-23 22:24 ` [PATCHv5 06/18] Bluetooth: Add new ERTM receive states for channel move Mat Martineau
2012-10-23 22:24 ` [PATCHv5 07/18] Bluetooth: Add move channel confirm handling Mat Martineau
2012-10-23 22:24 ` [PATCHv5 08/18] Bluetooth: Add state to hci_chan Mat Martineau
2012-10-23 22:24 ` [PATCHv5 09/18] Bluetooth: Move channel response Mat Martineau
2012-10-23 22:24 ` [PATCHv5 10/18] Bluetooth: Add logical link confirm Mat Martineau
2012-10-23 22:36 ` Marcel Holtmann
2012-10-23 22:24 ` [PATCHv5 11/18] Bluetooth: Add move confirm response handling Mat Martineau
2012-10-23 22:24 ` [PATCHv5 12/18] Bluetooth: Handle physical link completion Mat Martineau
2012-10-23 22:24 ` [PATCHv5 13/18] Bluetooth: Flag ACL frames as complete for AMP controllers Mat Martineau
2012-10-23 22:24 ` [PATCHv5 14/18] Bluetooth: Do not send data during channel move Mat Martineau
2012-10-23 22:24 ` [PATCHv5 15/18] Bluetooth: Configure appropriate timeouts for AMP controllers Mat Martineau
2012-10-23 22:24 ` [PATCHv5 16/18] Bluetooth: Ignore BR/EDR packet size constraints when fragmenting for AMP Mat Martineau
2012-10-23 22:24 ` Mat Martineau [this message]
2012-10-23 22:24 ` [PATCHv5 18/18] Bluetooth: Start channel move when socket option is changed Mat Martineau
2012-10-24 2:45 ` Gustavo Padovan
2012-10-23 22:38 ` [PATCHv5 00/18] L2CAP signaling for AMP channel create/move Marcel Holtmann
2012-10-24 4:58 ` Andrei Emeltchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351031063-11791-18-git-send-email-mathewm@codeaurora.org \
--to=mathewm@codeaurora.org \
--cc=andrei.emeltchenko.news@gmail.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=sunnyk@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).