linux-bluetooth.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Frédéric Danis" <frederic.danis@linux.intel.com>
To: linux-bluetooth@vger.kernel.org
Subject: [PATCH v7 04/16] adapter: Remove device class storage
Date: Wed, 24 Oct 2012 16:34:06 +0200	[thread overview]
Message-ID: <1351089258-25179-5-git-send-email-frederic.danis@linux.intel.com> (raw)
In-Reply-To: <1351089258-25179-1-git-send-email-frederic.danis@linux.intel.com>

---
 src/adapter.c |   18 +++++-------------
 src/adapter.h |    2 +-
 src/mgmt.c    |    2 +-
 3 files changed, 7 insertions(+), 15 deletions(-)

diff --git a/src/adapter.c b/src/adapter.c
index 6333837..310d1cf 100644
--- a/src/adapter.c
+++ b/src/adapter.c
@@ -756,8 +756,6 @@ void btd_adapter_class_changed(struct btd_adapter *adapter, uint8_t *new_class)
 	if (class == adapter->dev_class)
 		return;
 
-	write_local_class(&adapter->bdaddr, new_class);
-
 	adapter->dev_class = class;
 
 	if (main_opts.gatt_enabled) {
@@ -2169,18 +2167,11 @@ void btd_adapter_get_mode(struct btd_adapter *adapter, uint8_t *mode,
 		*pairable = adapter->pairable;
 }
 
-void btd_adapter_read_class(struct btd_adapter *adapter, uint8_t *major,
+void btd_adapter_get_major_minor(struct btd_adapter *adapter, uint8_t *major,
 								uint8_t *minor)
 {
-	uint8_t cls[3];
-
-	if (read_local_class(&adapter->bdaddr, cls) < 0) {
-		uint32_t class = htobl(main_opts.class);
-		memcpy(cls, &class, 3);
-	}
-
-	*major = cls[1];
-	*minor = cls[0];
+	*major = (adapter->dev_class >> 8) & 0xFF;
+	*minor = adapter->dev_class & 0xFF;
 }
 
 uint32_t btd_adapter_get_class(struct btd_adapter *adapter)
@@ -2249,7 +2240,6 @@ void btd_adapter_start(struct btd_adapter *adapter)
 
 	ba2str(&adapter->bdaddr, address);
 
-	adapter->dev_class = 0;
 	adapter->off_requested = FALSE;
 	adapter->up = TRUE;
 	adapter->discov_timeout = get_discoverable_timeout(address);
@@ -2507,6 +2497,8 @@ static void load_config(struct btd_adapter *adapter)
 	else
 		adapter->name = g_strdup(name);
 
+	/* Set class */
+	adapter->dev_class = main_opts.class;
 }
 
 gboolean adapter_init(struct btd_adapter *adapter, gboolean up)
diff --git a/src/adapter.h b/src/adapter.h
index d53c658..be69781 100644
--- a/src/adapter.h
+++ b/src/adapter.h
@@ -85,7 +85,7 @@ void btd_adapter_get_mode(struct btd_adapter *adapter, uint8_t *mode,
 						uint16_t *discoverable_timeout,
 						gboolean *pairable);
 
-void btd_adapter_read_class(struct btd_adapter *adapter, uint8_t *major,
+void btd_adapter_get_major_minor(struct btd_adapter *adapter, uint8_t *major,
 							uint8_t *minor);
 
 uint32_t btd_adapter_get_class(struct btd_adapter *adapter);
diff --git a/src/mgmt.c b/src/mgmt.c
index bef66cd..f179dfa 100644
--- a/src/mgmt.c
+++ b/src/mgmt.c
@@ -1105,7 +1105,7 @@ static void read_info_complete(int sk, uint16_t index, void *buf, size_t len)
 	else
 		adapter_name_changed(adapter, (char *) rp->name);
 
-	btd_adapter_read_class(adapter, &major, &minor);
+	btd_adapter_get_major_minor(adapter, &major, &minor);
 	mgmt_set_dev_class(index, major, minor);
 
 	btd_adapter_get_mode(adapter, &mode, NULL, NULL, NULL);
-- 
1.7.9.5


  parent reply	other threads:[~2012-10-24 14:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 14:34 [PATCH v7 00/16] Move storage config and names files to ini-file format Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 01/16] doc: Add settings storage documentation Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 02/16] adapter: Read name in storage at init Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 03/16] adaptername: Retrieve config name from adapter Frédéric Danis
2012-10-24 14:34 ` Frédéric Danis [this message]
2012-10-24 14:34 ` [PATCH v7 05/16] adapter: Move pairable read to load_config() Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 06/16] adapter: Read pairable timeout in storage at init Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 07/16] adapter: Read discoverable " Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 08/16] adapter: Read mode " Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 09/16] adapter: Move saved config to ini-file format Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 10/16] TODO: Add entry to remove storage convertion function Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 11/16] adapter: Move storage names to cache directory Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 12/16] event: Remove write of LastSeen info Frédéric Danis
2012-10-24 14:34 ` [PATCH v7 13/16] device: Retrieve name from cache directory Frédéric Danis
2012-10-25  9:52   ` Johan Hedberg
2012-10-24 14:34 ` [PATCH v7 14/16] dbusoob: Store device name in " Frédéric Danis
2012-10-25  9:54   ` Johan Hedberg
2012-10-24 14:34 ` [PATCH v7 15/16] input: Retrieve device name from " Frédéric Danis
2012-10-25  9:55   ` Johan Hedberg
2012-10-24 14:34 ` [PATCH v7 16/16] hcitool: Retrieve names " Frédéric Danis
2012-10-25  9:55   ` Johan Hedberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1351089258-25179-5-git-send-email-frederic.danis@linux.intel.com \
    --to=frederic.danis@linux.intel.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).