From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: Gustavo Padovan <gustavo@padovan.org>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: Notify about device registration before power on
Date: Wed, 31 Oct 2012 12:34:08 -0700 [thread overview]
Message-ID: <1351712048.1828.17.camel@aeonflux> (raw)
In-Reply-To: <20121031190907.GA3631@x220.P-661HNU-F1>
Hi Gustavo,
> > > It is important that the monitor interface gets notified about
> > > a new device before its power on procedure has been started.
> > >
> > > For some reason that is no longer working as expected and the power
> > > on procedure runs first. It is safe to just notify about device
> > > registration and trigger the power on procedure afterwards.
> > >
> > > Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
> > > ---
> > > net/bluetooth/hci_core.c | 4 ++--
> > > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > Patch has been applied to bluetooth-next. Thanks.
>
> I guess you mean bluetooth.git? (that's where the patch is right now -
> not bluetooth-next). Also, I don't think the Cc: stable addition was
> necessary since this scheduling behavior seems to be something only
> introduced for 3.7 (not 100% sure about this though).
I did not send this to stable, because I think it is 3.7-rc only
behavior. Feel free to test it. With the help of btmon it is really easy
to see if the New Index event arrives before the first HCI command or
not. Remember that this only applies for newly attached devices and
btmon already running.
Regards
Marcel
prev parent reply other threads:[~2012-10-31 19:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-30 8:35 [PATCH] Bluetooth: Notify about device registration before power on Marcel Holtmann
2012-10-30 11:08 ` Johan Hedberg
2012-10-31 18:18 ` Gustavo Padovan
2012-10-31 19:09 ` Johan Hedberg
2012-10-31 19:34 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1351712048.1828.17.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).