From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/3] Bluetooth: Use proper invalid value for tx_power
Date: Wed, 07 Nov 2012 16:53:10 +0100 [thread overview]
Message-ID: <1352303590.16204.0.camel@aeonflux> (raw)
In-Reply-To: <1352239600-5840-1-git-send-email-johan.hedberg@gmail.com>
Hi Johan,
> The core specification defines 127 as the "not available" value (well,
> "reserved" for BR/EDR and "not available" for LE - but essentially the
> same). Therefore, instead of testing for 0 (which is in fact a valid
> value) we should be using this invalid value to test if the tx_power is
> available.
>
> Signed-off-by: Johan Hedberg <johan.hedberg@intel.com>
> ---
> include/net/bluetooth/hci.h | 3 +++
> net/bluetooth/hci_core.c | 2 ++
> net/bluetooth/hci_event.c | 2 ++
> net/bluetooth/mgmt.c | 2 +-
> 4 files changed, 8 insertions(+), 1 deletion(-)
Acked-by: Marcel Holtmann <marcel@holtmann.org>
Regards
Marcel
next prev parent reply other threads:[~2012-11-07 15:53 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 22:06 [PATCH 1/3] Bluetooth: Use proper invalid value for tx_power Johan Hedberg
2012-11-06 22:06 ` [PATCH 2/3] Bluetooth: Add support for setting LE advertising data Johan Hedberg
2012-11-07 15:55 ` Marcel Holtmann
2012-11-08 0:17 ` Johan Hedberg
2012-11-06 22:06 ` [PATCH 3/3] Bluetooth: Fix updating advertising state flags and data Johan Hedberg
2012-11-07 15:56 ` Marcel Holtmann
2012-11-07 15:53 ` Marcel Holtmann [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-11-08 0:19 [PATCH 1/3] Bluetooth: Use proper invalid value for tx_power Johan Hedberg
2012-11-08 0:22 ` Johan Hedberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1352303590.16204.0.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox