Linux bluetooth development
 help / color / mirror / Atom feed
From: Szymon Janc <szymon.janc@tieto.com>
To: <linux-bluetooth@vger.kernel.org>
Cc: Szymon Janc <szymon.janc@tieto.com>
Subject: [PATCH 2/3] avrcp: Fix dead assignments in ct_set_setting
Date: Tue, 13 Nov 2012 13:52:39 +0100	[thread overview]
Message-ID: <1352811160-12722-2-git-send-email-szymon.janc@tieto.com> (raw)
In-Reply-To: <1352811160-12722-1-git-send-email-szymon.janc@tieto.com>

Value stored in val is never read before writing it again. After
fixing val same applies to attr variable.

---
 audio/avrcp.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/audio/avrcp.c b/audio/avrcp.c
index e3ce2fb..2517df8 100644
--- a/audio/avrcp.c
+++ b/audio/avrcp.c
@@ -1944,8 +1944,8 @@ static bool ct_set_setting(struct media_player *mp, const char *key,
 					const char *value, void *user_data)
 {
 	struct avrcp_player *player = user_data;
-	int attr = attr_to_val(key);
-	int val = attrval_to_val(attr, value);
+	int attr;
+	int val;
 	struct avrcp *session;
 
 	session = player->sessions->data;
-- 
1.7.9.5


  reply	other threads:[~2012-11-13 12:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-13 12:52 [PATCH 1/3] avctp: Fix dead assignment in control_response Szymon Janc
2012-11-13 12:52 ` Szymon Janc [this message]
2012-11-13 12:52 ` [PATCH 3/3] network: Fix dead assignment in connect_cb Szymon Janc
2012-11-13 13:14 ` [PATCH 1/3] avctp: Fix dead assignment in control_response Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1352811160-12722-2-git-send-email-szymon.janc@tieto.com \
    --to=szymon.janc@tieto.com \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox