Linux bluetooth development
 help / color / mirror / Atom feed
From: Mikel Astiz <mikel.astiz.oss@gmail.com>
To: linux-bluetooth@vger.kernel.org
Cc: luiz.von.dentz@intel.com, Mikel Astiz <mikel.astiz@bmw-carit.de>
Subject: [RFC] doc: Split media transport volume into two parts
Date: Mon, 26 Nov 2012 11:46:31 +0100	[thread overview]
Message-ID: <1353926791-8769-1-git-send-email-mikel.astiz.oss@gmail.com> (raw)

From: Mikel Astiz <mikel.astiz@bmw-carit.de>

Separate the input and output audio volumes in two independent
properties in order to control both speaker and microphone gains while
doing HSP/HFP.
---
This property was introduced quite recently but never implemented. Shouldn't we split it into two separate properties?

It wouldn't do much harm for the A2DP transports and it would be needed for HSP/HFP.

 doc/media-api.txt | 16 ++++++++++++----
 1 file changed, 12 insertions(+), 4 deletions(-)

diff --git a/doc/media-api.txt b/doc/media-api.txt
index b4f2fc6..6515e5f 100644
--- a/doc/media-api.txt
+++ b/doc/media-api.txt
@@ -375,10 +375,18 @@ Properties	object Device [readonly]
 
 			Possible Values: "HCI" or "PCM"
 
-		uint16 Volume [readwrite]
+		uint16 InputVolume [readwrite] [optional]
 
-			Optional. Indicates volume level of the transport,
-			this property is only writeable when the transport was
-			acquired by the sender.
+			Indicates volume level of the transport's incoming
+			audio stream, if any. This property is only writeable
+			when the transport was acquired by the sender.
+
+			Possible Values: 0-127
+
+		uint16 OutputVolume [readwrite] [optional]
+
+			Indicates volume level of the transport's outgoing
+			audio stream, if any. This property is only writeable
+			when the transport was acquired by the sender.
 
 			Possible Values: 0-127
-- 
1.7.11.7


             reply	other threads:[~2012-11-26 10:46 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-26 10:46 Mikel Astiz [this message]
2012-11-26 11:40 ` [RFC] doc: Split media transport volume into two parts Luiz Augusto von Dentz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1353926791-8769-1-git-send-email-mikel.astiz.oss@gmail.com \
    --to=mikel.astiz.oss@gmail.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.von.dentz@intel.com \
    --cc=mikel.astiz@bmw-carit.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox