From: Marcel Holtmann <marcel@holtmann.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] build: Check for UDEV before setting rulesdir/rules_DATA
Date: Wed, 19 Dec 2012 15:06:27 +0100 [thread overview]
Message-ID: <1355925987.1827.5.camel@aeonflux> (raw)
In-Reply-To: <1355921804-12533-1-git-send-email-anderson.lizardo@openbossa.org>
Hi Anderson,
> Without this check, UDEV_DIR will be empty and an empty "/rules.d"
> directory is created on DESTDIR.
> ---
> Makefile.am | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Makefile.am b/Makefile.am
> index a482b54..c10c1fa 100644
> --- a/Makefile.am
> +++ b/Makefile.am
> @@ -174,6 +174,7 @@ test_scripts =
> include Makefile.tools
> include Makefile.obexd
>
> +if UDEV
> rulesdir = @UDEV_DIR@/rules.d
>
> udev_files =
> @@ -187,6 +188,7 @@ EXTRA_DIST += tools/hid2hci.rules
> rules_DATA = $(foreach file,$(udev_files), tools/97-$(notdir $(file)))
>
> CLEANFILES += $(rules_DATA)
> +endif
great catch, but I fixed this differently by hiding this behind the
HID2HCI condition.
On a side note, you fix has the issue that EXTRA_DIST is now skipped and
that means it would have broken make distcheck by not including the
actual rule file.
Regards
Marcel
next prev parent reply other threads:[~2012-12-19 14:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-19 12:56 [PATCH BlueZ] build: Check for UDEV before setting rulesdir/rules_DATA Anderson Lizardo
2012-12-19 14:06 ` Marcel Holtmann [this message]
2012-12-19 15:05 ` Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355925987.1827.5.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox