From: Marcel Holtmann <marcel@holtmann.org>
To: Johan Hedberg <johan.hedberg@gmail.com>
Cc: Syam Sidhardhan <s.syam@samsung.com>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] Bluetooth: Fix to update EIR for uuid16 properly
Date: Sat, 22 Dec 2012 08:39:04 -0800 [thread overview]
Message-ID: <1356194344.29264.16.camel@aeonflux> (raw)
In-Reply-To: <20121221193112.GA31432@x220.ger.corp.intel.com>
Hi Johan,
> > If we register a uuid other than uuid16, especially custom 128 bit uuid
> > then nothing is updated in the EIR and it was broken.
> >
> > After registering a 16 bit uuid. ex: "sdptool add SP", we can see the
> > uuid in the EIR as below.
> > < 0000: 01 52 0c f1 00 08 09 52 65 64 77 6f 6f 64 15 03 .R.....Redwood..
> > 0010: 01 11 32 11 2f 11 06 11 05 11 0a 11 0e 11 0c 11 ..2./...........
> > 0020: 1f 11 12 11 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0070: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00f0: 00 00 00 00 00 .....
> > > 0000: 04 0e 04 01 52 0c 00 ....R..
> >
> > But after register a user defined 128 bit uuid, nothing is
> > updated in the EIR.
> >
> > < 0000: 01 52 0c f1 00 08 09 52 65 64 77 6f 6f 64 00 00 .R.....Redwood..
> > 0010: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0020: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0030: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0040: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0050: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0060: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0070: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 0090: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00a0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00c0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00d0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
> > 00f0: 00 00 00 00 00 .....
> > > 0000: 04 0e 04 01 52 0c 00 ....R..
> >
> > With this fix, we can see the EIR is updated properly.
> >
> > Signed-off-by: Syam Sidhardhan <s.syam@samsung.com>
> > ---
> > net/bluetooth/mgmt.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
> > index f559b96..512a3f5 100644
> > --- a/net/bluetooth/mgmt.c
> > +++ b/net/bluetooth/mgmt.c
> > @@ -514,8 +514,6 @@ static void create_eir(struct hci_dev *hdev, u8 *data)
> > u16 uuid16;
> >
> > uuid16 = get_uuid16(uuid->uuid);
> > - if (uuid16 == 0)
> > - return;
> >
> > if (uuid16 < 0x1100)
> > continue;
>
> Nak. The bug is real and should be fixed but your fix is wrong. The
> right fix it to convert this return statement into a continue statement
> since we do still want to check for a 0 return value from get_uuid16.
>
> Along with this patch please prepare another one to increment the mgmt
> revision. These two should go together to upstream trees so that we can
> introduce a check in user space to know whether it's safe to pass
> non-16bit UUIDs to the kernel or not.
I want a fix that introduces also support for 32-bit and 128-bit UUIDs
now. No paper over the hole fixing here.
Regards
Marcel
next prev parent reply other threads:[~2012-12-22 16:39 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-21 13:44 [PATCH 1/2] Bluetooth: Fix to update EIR for uuid16 properly Syam Sidhardhan
2012-12-21 13:44 ` [PATCH 2/2] Bluetooth: Fix ACL alive for long in case of non pariable devices Syam Sidhardhan
2013-01-07 20:49 ` Syam Sidhardhan
2013-06-26 11:33 ` Syam Sidhardhan
2013-06-26 12:48 ` Szymon Janc
2013-06-28 10:17 ` Syam Sidhardhan
2012-12-21 19:31 ` [PATCH 1/2] Bluetooth: Fix to update EIR for uuid16 properly Johan Hedberg
2012-12-22 16:39 ` Marcel Holtmann [this message]
2012-12-24 11:46 ` Syam Sidhardhan
2012-12-24 16:45 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1356194344.29264.16.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=s.syam@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).