From: Marcel Holtmann <marcel@holtmann.org>
To: Jaganath Kanakkassery <jaganath.k@samsung.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 1/2] audio: Replace g_hash_table_contains() with g_hash_table_lookup()
Date: Mon, 07 Jan 2013 19:22:34 -0800 [thread overview]
Message-ID: <1357615354.1806.19.camel@aeonflux> (raw)
In-Reply-To: <1357562033-26230-1-git-send-email-jaganath.k@samsung.com>
Hi Jaganath,
> g_hash_table_contains() is supported only from GLib 2.32. If BlueZ has to
> build against GLib 2.28 this patch replaces g_hash_table_contains() to
> g_hash_table_lookup()
> ---
> profiles/audio/player.c | 7 ++++++-
> 1 file changed, 6 insertions(+), 1 deletion(-)
>
> diff --git a/profiles/audio/player.c b/profiles/audio/player.c
> index 8748893..4198bdb 100644
> --- a/profiles/audio/player.c
> +++ b/profiles/audio/player.c
> @@ -172,8 +172,13 @@ static gboolean get_status(const GDBusPropertyTable *property,
> static gboolean setting_exists(const GDBusPropertyTable *property, void *data)
> {
> struct media_player *mp = data;
> + const char *value;
> +
> + value = g_hash_table_lookup(mp->settings, property->name);
return value ? TRUE : FALSE;
Regards
Marcel
prev parent reply other threads:[~2013-01-08 3:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-07 12:33 [PATCH 1/2] audio: Replace g_hash_table_contains() with g_hash_table_lookup() Jaganath Kanakkassery
2013-01-07 12:33 ` [PATCH 2/2] shared: Fix build break Jaganath Kanakkassery
2013-01-08 3:20 ` Marcel Holtmann
2013-01-07 13:12 ` [PATCH 1/2] audio: Replace g_hash_table_contains() with g_hash_table_lookup() Ludek Finstrle
2013-01-07 13:52 ` Jaganath Kanakkassery
2013-01-07 20:00 ` Luiz Augusto von Dentz
2013-01-08 3:24 ` Marcel Holtmann
2013-01-08 3:22 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357615354.1806.19.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=jaganath.k@samsung.com \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).