From: Marcel Holtmann <marcel@holtmann.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v2 BlueZ] lib: Fix SDP_TEXT_STR16/SDP_URL_STR16 parsing
Date: Tue, 08 Jan 2013 18:25:23 -0800 [thread overview]
Message-ID: <1357698323.1806.41.camel@aeonflux> (raw)
In-Reply-To: <1357686325-29529-1-git-send-email-anderson.lizardo@openbossa.org>
Hi Anderson,
> sdp_extract_attr() uses the "size" parameter to return the number of
> bytes consumed when parsing SDP Data Elements. This size is used to
> advance a buffer pointer to parse next element.
>
> This size was being incorrectly calculated for SDP_{TEXT,URL}_STR16 in
> extract_str(), where the string length was added twice. The string
> length is already added later in the function for {TEXT,URL}_STR{8,16}
> by this statement:
>
> *len += n;
> ---
> lib/sdp.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied.
Regards
Marcel
next prev parent reply other threads:[~2013-01-09 2:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 18:43 [PATCH BlueZ 1/2] unit: Add initial tests for sdp_extract_attr() Anderson Lizardo
2013-01-08 18:43 ` [PATCH BlueZ 2/2] lib: Fix SDP_TEXT_STR16/SDP_URL_STR16 parsing Anderson Lizardo
2013-01-08 19:13 ` Marcel Holtmann
2013-01-08 20:27 ` Anderson Lizardo
2013-01-08 22:41 ` Marcel Holtmann
2013-01-08 23:05 ` [PATCH v2 BlueZ] " Anderson Lizardo
2013-01-09 2:25 ` Marcel Holtmann [this message]
2013-01-08 19:10 ` [PATCH BlueZ 1/2] unit: Add initial tests for sdp_extract_attr() Marcel Holtmann
2013-01-08 20:45 ` Anderson Lizardo
2013-01-08 22:46 ` Marcel Holtmann
2013-01-09 15:14 ` Anderson Lizardo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357698323.1806.41.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=anderson.lizardo@openbossa.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).