From: Marcel Holtmann <marcel@holtmann.org>
To: Lubomir Rintel <lkundrak@v3.sk>
Cc: David Woodhouse <dwmw2@infradead.org>,
Ben Hutchings <ben@decadent.org.uk>,
libertas-dev@lists.infradead.org,
linux-bluetooth@vger.kernel.org,
Gustavo Padovan <gustavo@padovan.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in alternate place
Date: Tue, 08 Jan 2013 18:28:58 -0800 [thread overview]
Message-ID: <1357698538.1806.43.camel@aeonflux> (raw)
In-Reply-To: <1357689361-7969-2-git-send-email-lkundrak@v3.sk>
Hi Lubomir,
> linux-firmware ships the sd8688* firmware images that are shared with
> libertas_sdio WiFi driver under libertas/. libertas_sdio looks in both places
> and so should we.
>
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---
> drivers/bluetooth/btmrvl_sdio.c | 24 ++++++++++++++++++++++--
> drivers/bluetooth/btmrvl_sdio.h | 6 ++++--
> 2 files changed, 26 insertions(+), 4 deletions(-)
NAK from me on this one. I do not want the driver to check two
locations. That is what userspace can work around.
If we want to unify the location between the WiFi driver and the
Bluetooth driver, I am fine with that, but seriously, just pick one over
the other. I do not care which one.
Regards
Marcel
next prev parent reply other threads:[~2013-01-09 2:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-01-08 23:56 sd8688 firmware location Lubomir Rintel
2013-01-08 23:56 ` [PATCH] Bluetooth: btmrvl_sdio: look for sd8688 firmware in alternate place Lubomir Rintel
2013-01-09 2:28 ` Marcel Holtmann [this message]
2013-01-09 2:43 ` Bing Zhao
2013-01-09 6:31 ` Lubomir Rintel
2013-01-09 6:35 ` Marcel Holtmann
2013-01-18 7:33 ` Lubomir Rintel
2013-01-21 1:12 ` Ben Hutchings
2013-01-27 11:21 ` Lubomir Rintel
2013-02-18 3:18 ` Ben Hutchings
2013-01-18 7:37 ` [PATCH] bluetooth: btmrvl_sdio: look for sd8688 firmware in proper location Lubomir Rintel
2013-01-18 7:58 ` Marcel Holtmann
2013-01-19 19:01 ` Lubomir Rintel
2013-01-19 20:23 ` Marcel Holtmann
2013-01-08 23:57 ` [PATCH] Move sd8688*.bin images away from libertas tree Lubomir Rintel
2013-01-09 22:45 ` sd8688 firmware location Dan Williams
2013-01-10 1:20 ` Bing Zhao
2013-01-18 7:39 ` [PATCH] libertas sdio: look for 8688 firmware in common location Lubomir Rintel
2013-01-21 1:13 ` sd8688 firmware location Ben Hutchings
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1357698538.1806.43.camel@aeonflux \
--to=marcel@holtmann.org \
--cc=ben@decadent.org.uk \
--cc=dwmw2@infradead.org \
--cc=gustavo@padovan.org \
--cc=johan.hedberg@gmail.com \
--cc=libertas-dev@lists.infradead.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkundrak@v3.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).