Linux bluetooth development
 help / color / mirror / Atom feed
From: Marcel Holtmann <marcel@holtmann.org>
To: Anderson Lizardo <anderson.lizardo@openbossa.org>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ 1/3] unit: Reuse define_test() macro for /TP/SERVER/BRW/* tests
Date: Wed, 09 Jan 2013 11:08:49 -0800	[thread overview]
Message-ID: <1357758529.1806.46.camel@aeonflux> (raw)
In-Reply-To: <1357744762-5111-1-git-send-email-anderson.lizardo@openbossa.org>

Hi Anderson,

> This is made possible by adding the mtu parameter, given
> /TP/SERVER/BRW/* tests use MTU of 672.
> ---
>  unit/test-sdp.c |   24 ++++++------------------
>  1 file changed, 6 insertions(+), 18 deletions(-)
> 
> diff --git a/unit/test-sdp.c b/unit/test-sdp.c
> index 315a5cd..e9cbcdf 100644
> --- a/unit/test-sdp.c
> +++ b/unit/test-sdp.c
> @@ -68,34 +68,22 @@ struct test_data {
>  		.cont_len = cont,				\
>  	}
>  
> -#define define_test(name, args...) \
> +#define define_test(name, _mtu, args...) \
>  	do {								\
>  		const struct sdp_pdu pdus[] = {				\
>  			args, { }, { }					\
>  		};							\
>  		static struct test_data data;				\
> -		data.mtu = 48;						\
> +		data.mtu = _mtu;					\

so using _mtu instead of mtu was the trick here. For the heck of it I
could not figure that one out. So in the end I gave up on it and
hardcoded it :(

Patch has been applied.

Regards

Marcel



  parent reply	other threads:[~2013-01-09 19:08 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-01-09 15:19 [PATCH BlueZ 1/3] unit: Reuse define_test() macro for /TP/SERVER/BRW/* tests Anderson Lizardo
2013-01-09 15:19 ` [PATCH BlueZ 2/3] unit: Rename x_pdu() macro on SDP test program Anderson Lizardo
2013-01-09 19:10   ` Marcel Holtmann
2013-01-09 15:19 ` [PATCH v2 BlueZ 3/3] unit: Implement tests for sdp_extract_attr() Anderson Lizardo
2013-01-09 19:50   ` Marcel Holtmann
2013-01-09 20:13     ` Anderson Lizardo
2013-01-09 19:08 ` Marcel Holtmann [this message]
2013-01-09 20:06   ` [PATCH BlueZ 1/3] unit: Reuse define_test() macro for /TP/SERVER/BRW/* tests Anderson Lizardo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1357758529.1806.46.camel@aeonflux \
    --to=marcel@holtmann.org \
    --cc=anderson.lizardo@openbossa.org \
    --cc=linux-bluetooth@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox